From: Hartmut Knaack <knaack.h@gmx.de>
To: Chris Ruffin <cmruffin@gmail.com>, linux-iio@vger.kernel.org
Subject: Re: [PATCH] staging: iio: accel: remove unnecessary syntax
Date: Mon, 15 Sep 2014 23:37:08 +0200 [thread overview]
Message-ID: <54175C04.70302@gmx.de> (raw)
In-Reply-To: <1410737937-10773-1-git-send-email-cmruffin@gmail.com>
Chris Ruffin schrieb, Am 15.09.2014 01:38:
> The else clause in the conditional of lis3l02dq_data_rdy_trig_poll()
> does not make consistent use of braces with the rest of the
> conditional. Fix this coding style problem by removing the
> unnecessary conditional altogether.
>
> Signed-off-by: Chris Ruffin <cmruffin@gmail.com>
Acked-by: Hartmut Knaack <knaack.h@gmx.de>
> ---
> drivers/staging/iio/accel/lis3l02dq_ring.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/accel/lis3l02dq_ring.c b/drivers/staging/iio/accel/lis3l02dq_ring.c
> index 1d934ee..9efc77b 100644
> --- a/drivers/staging/iio/accel/lis3l02dq_ring.c
> +++ b/drivers/staging/iio/accel/lis3l02dq_ring.c
> @@ -34,8 +34,9 @@ irqreturn_t lis3l02dq_data_rdy_trig_poll(int irq, void *private)
> if (st->trigger_on) {
> iio_trigger_poll(st->trig);
> return IRQ_HANDLED;
> - } else
> - return IRQ_WAKE_THREAD;
> + }
> +
> + return IRQ_WAKE_THREAD;
> }
>
> static const u8 read_all_tx_array[] = {
>
next prev parent reply other threads:[~2014-09-15 21:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-14 23:38 [PATCH] staging: iio: accel: remove unnecessary syntax Chris Ruffin
2014-09-15 21:37 ` Hartmut Knaack [this message]
2014-09-21 12:18 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54175C04.70302@gmx.de \
--to=knaack.h@gmx.de \
--cc=cmruffin@gmail.com \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).