From: Jonathan Cameron <jic23@kernel.org>
To: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
Lee Jones <lee.jones@linaro.org>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-iio@vger.kernel.org, Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-pm@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Grant Likely <grant.likely@linaro.org>,
devicetree@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Joe Perches <joe@perches.com>,
linux-api@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, support.opensource@diasemi.com
Subject: Re: [PATCH 2/8] mfd: da9150: Add DT binding documentation for core
Date: Sat, 27 Sep 2014 11:36:30 +0100 [thread overview]
Message-ID: <5426932E.7060609@kernel.org> (raw)
In-Reply-To: <b71815ff49a1cabe2c7907a96cc1be34f924648e.1411396719.git.Adam.Thomson.Opensource@diasemi.com>
On 23/09/14 11:53, Adam Thomson wrote:
> Signed-off-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Obviously this really wants a review from one of the device tree guys, but I
have a few
bits based on what Mark has recently said in other reviews ;)
> ---
> Documentation/devicetree/bindings/mfd/da9150.txt | 41 ++++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/da9150.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/da9150.txt b/Documentation/devicetree/bindings/mfd/da9150.txt
> new file mode 100644
> index 0000000..d7de150
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/da9150.txt
> @@ -0,0 +1,41 @@
> +Dialog Semiconductor DA9150 Combined Charger/Fuel-Gauge MFD bindings
> +
> +DA9150 consists of a group of sub-devices (I2C Only):
What does I2C only add to the description?
> +
> +Device Description
> +------ -----------
> +da9150-gpadc : IIO - GPADC
Given usual aversion to anything driver specific in the device tree description
you probably
just want to describe what they do rather than what subsystem provides the driver.
> +da9150-charger : Power Supply (Charger)
> +
> +======
> +
> +Required properties:
> +- compatible : Should be "dlg,da9150"
> +- reg: Specifies the I2C slave address
> +- interrupt-parent: Specifies the phandle of the interrupt controller to which
> + the IRQs from da9150 are delivered to.
> +- interrupts: IRQ line info for da9150 chip.
Cross refer to the standard interrupts doc for these...
> +- interrupt-controller: da9150 has internal IRQs (own IRQ domain).
> +
> +Sub-devices:
> +- da9150-gpadc: See Documentation/devicetree/bindings/iio/adc/da9150-gpadc.txt
> +- da9150-charger: See Documentation/devicetree/bindings/power/da9150-charger.txt
> +
> +
> +Example:
> +
> + charger_fg: da9150@58 {
> + compatible = "dlg,da9150";
> + reg = <0x58>;
> + interrupt-parent = <&gpio6>;
> + interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-controller;
> +
> + gpadc: da9150-gpadc {
> + ...
> + };
> +
> + da9150-charger {
> + ...
> + };
> + };
> --
> 1.9.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-09-27 10:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 10:53 [PATCH v3 0/8] Add initial support for DA9150 Charger & Fuel-Gauge IC Adam Thomson
2014-09-23 10:53 ` [PATCH 1/8] mfd: Add support for DA9150 combined charger & fuel-gauge device Adam Thomson
2014-09-27 10:33 ` Jonathan Cameron
2014-09-23 10:53 ` [PATCH 2/8] mfd: da9150: Add DT binding documentation for core Adam Thomson
2014-09-27 10:36 ` Jonathan Cameron [this message]
2014-10-07 13:47 ` Opensource [Adam Thomson]
2014-09-23 10:53 ` [PATCH 3/8] iio: Add support for DA9150 GPADC Adam Thomson
2014-09-27 10:49 ` Jonathan Cameron
2014-10-07 14:55 ` Opensource [Adam Thomson]
2014-10-07 19:36 ` Jonathan Cameron
2014-10-09 14:29 ` Opensource [Adam Thomson]
2014-10-11 22:47 ` Hartmut Knaack
2014-10-15 10:34 ` Opensource [Adam Thomson]
2014-09-23 10:53 ` [PATCH 4/8] iio: da9150: Add DT binding documentation for GPADC Adam Thomson
2014-09-27 10:52 ` Jonathan Cameron
2014-09-23 10:53 ` [PATCH 5/8] power: Add support for DA9150 Charger Adam Thomson
2014-09-27 11:09 ` Jonathan Cameron
2014-09-23 10:53 ` [PATCH 6/8] power: da9150: Add DT binding documentation for charger Adam Thomson
2014-09-23 10:53 ` [PATCH 7/8] MAINTAINERS: Include DA9150 files in Dialog Semiconductor support list Adam Thomson
2014-09-23 10:53 ` [PATCH 8/8] iio: Add ABI documentation for input current readings Adam Thomson
2014-09-27 10:23 ` Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2014-06-11 11:11 [PATCH 0/8] Add initial support for DA9150 Charger & Fuel-Gauge IC Adam Thomson
2014-06-11 11:11 ` [PATCH 2/8] mfd: da9150: Add DT binding documentation for core Adam Thomson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5426932E.7060609@kernel.org \
--to=jic23@kernel.org \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=akpm@linux-foundation.org \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=joe@perches.com \
--cc=lee.jones@linaro.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
--cc=sre@kernel.org \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).