From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:50043 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751573AbaJYTlD (ORCPT ); Sat, 25 Oct 2014 15:41:03 -0400 Message-ID: <544BFCCE.7000308@kernel.org> Date: Sat, 25 Oct 2014 20:41:02 +0100 From: Jonathan Cameron MIME-Version: 1.0 To: Hartmut Knaack , IIO CC: David Barksdale Subject: Re: [PATCH]iio:humidity:si7020: cleanup read_raw and probe References: <544BE747.80403@gmx.de> In-Reply-To: <544BE747.80403@gmx.de> Content-Type: text/plain; charset=iso-8859-15 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 25/10/14 19:09, Hartmut Knaack wrote: > When reading temperature or humidity values, a shift of two bits to the right > needs to be applied, and only for the humidity channel a mask of the lower > 12 bits needs to be applied. This reduces code repetition. > During probe, i2c_set_clientdata() was used, although its counterpart was not, > so drop it. > > Signed-off-by: Hartmut Knaack Applied to the togreg branch of iio.git, initially pushed out as testing. Thanks for the cleanup. J > --- > diff --git a/drivers/iio/humidity/si7020.c b/drivers/iio/humidity/si7020.c > index 62d74d3..b541646 100644 > --- a/drivers/iio/humidity/si7020.c > +++ b/drivers/iio/humidity/si7020.c > @@ -56,10 +56,9 @@ static int si7020_read_raw(struct iio_dev *indio_dev, > SI7020CMD_RH_HOLD); > if (ret < 0) > return ret; > - if (chan->type == IIO_TEMP) > - *val = ret >> 2; > - else > - *val = (ret & 0x3FFF) >> 2; > + *val = ret >> 2; > + if (chan->type == IIO_HUMIDITYRELATIVE) > + *val &= GENMASK(11, 0); > return IIO_VAL_INT; > case IIO_CHAN_INFO_SCALE: > if (chan->type == IIO_TEMP) > @@ -133,7 +132,6 @@ static int si7020_probe(struct i2c_client *client, > > data = iio_priv(indio_dev); > *data = client; > - i2c_set_clientdata(client, indio_dev); > > indio_dev->dev.parent = &client->dev; > indio_dev->name = dev_name(&client->dev); > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >