Re: [PATCH 1/2] iio: adc: Cosmic Circuits 10001 ADC driver

Lars-Peter Clausen
2014-10-31T19:44:23Z

On 10/31/2014 06:19 PM, Lars-Peter Clausen wrote:
> On 10/29/2014 09:45 PM, Ezequiel Garcia wrote:
>> From: Phani Movva <Phani.Movva@imgtec.com>
>>
>> This commit adds support for Cosmic Circuits 10001 10-bit ADC device.
>>
>> Signed-off-by: Phani Movva <Phani.Movva@imgtec.com>
>> Signed-off-by: Naidu Tellapati <Naidu.Tellapati@imgtec.com>
>> [Ezequiel: code style cleaning]
>> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@imgtec.com>
>
> Looks very good. Just a few very minor issues.

One thing I forgot to mention. We use indio_dev for the name of the struct
iio_dev variable. Please use this in this driver as well, makes it easier to
follow and review the code.

- Lars