Re: [PATCH 1/2] iio: adc: Cosmic Circuits 10001 ADC driver

Ezequiel Garcia
2014-11-04T23:48:37Z

On 10/31/2014 05:26 PM, Peter Meerwald wrote:
> Hi,
>
>> This commit adds support for Cosmic Circuits 10001 10-bit ADC device.
>
> some more comments & nitpicking...
>
> datasheet URL available?
>

Not right now, but I'm working on it. I'll try to push one if I get the
permission.

>> Signed-off-by: Phani Movva <Phani.Movva@imgtec.com>
>> Signed-off-by: Naidu Tellapati <Naidu.Tellapati@imgtec.com>
>> [Ezequiel: code style cleaning]
>> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@imgtec.com>
>> ---
>> drivers/iio/adc/Kconfig | 7 +
>> drivers/iio/adc/Makefile | 1 +
>> drivers/iio/adc/cc_10001_adc.c | 421 +++++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 429 insertions(+)
>> create mode 100644 drivers/iio/adc/cc_10001_adc.c
>>
>> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
>> index 88bdc8f..be86c99 100644
>> --- a/drivers/iio/adc/Kconfig
>> +++ b/drivers/iio/adc/Kconfig
>> @@ -127,6 +127,13 @@ config AT91_ADC
>> help
>> Say yes here to build support for Atmel AT91 ADC.
>>
>> +config CC_10001_ADC
>> + tristate "Cosmic Circuits 10001 ADC driver"
>> + select IIO_BUFFER
>> + select IIO_TRIGGERED_BUFFER
>
> would there be a meaningful 'depends on'?
>

This ADC will be available in a MIPS SoC from Imagination Technologies,
called "Pistachio", so we would put a "depends on MACH_PISTACHIO", once
the support for the SoC hits mainline (which should happen anytime soon).

For the time being, we are pushing some of the peripherals so we can put
the pieces progressively.

I've fixed the driver as per all your comments, thanks a lot for the review!
--
Ezequiel