Re: [PATCH 1/2] iio: adc: Cosmic Circuits 10001 ADC driver

Jonathan Cameron
2014-11-05T13:41:23Z

On 04/11/14 23:41, Ezequiel Garcia wrote:
> Hi Hartmut,
>
> Thanks for the review. It seems I missed lots of details in this driver!
*laughs*

Actually a pretty clean driver - these guys just do a very good job
of a fine detail review! (a lot less gets through than used to when
it was mostly myself doing the reviewing) Which is good because I get
far fewer little cleanups.

>
> On 11/01/2014 08:11 PM, Hartmut Knaack wrote:
> [..]
>
>>> +
>>> + dev->dev.parent = &pdev->dev;
>>> + dev->name = dev_name(&pdev->dev);
>>> + dev->info = &cc_10001_adc_info;
>>> + dev->modes = INDIO_DIRECT_MODE;
>>> +
>>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> Check for error?
>
> Nope, this one is used like this. See the comment in lib/devres.c.
>
> Thanks again!
>