From: Jonathan Cameron <jic23@kernel.org>
To: Ezequiel Garcia <ezequiel.garcia@imgtec.com>,
Hartmut Knaack <knaack.h@gmx.de>,
linux-iio@vger.kernel.org, lars@metafoo.de,
Naidu.Tellapati@imgtec.com, james.hartley@imgtec.com,
abrestic@chromium.org
Cc: Phani Movva <Phani.Movva@imgtec.com>
Subject: Re: [PATCH 1/2] iio: adc: Cosmic Circuits 10001 ADC driver
Date: Wed, 05 Nov 2014 13:41:21 +0000 [thread overview]
Message-ID: <545A2901.1000802@kernel.org> (raw)
In-Reply-To: <54596441.6060009@imgtec.com>
On 04/11/14 23:41, Ezequiel Garcia wrote:
> Hi Hartmut,
>
> Thanks for the review. It seems I missed lots of details in this driver!
*laughs*
Actually a pretty clean driver - these guys just do a very good job
of a fine detail review! (a lot less gets through than used to when
it was mostly myself doing the reviewing) Which is good because I get
far fewer little cleanups.
>
> On 11/01/2014 08:11 PM, Hartmut Knaack wrote:
> [..]
>
>>> +
>>> + dev->dev.parent = &pdev->dev;
>>> + dev->name = dev_name(&pdev->dev);
>>> + dev->info = &cc_10001_adc_info;
>>> + dev->modes = INDIO_DIRECT_MODE;
>>> +
>>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> Check for error?
>
> Nope, this one is used like this. See the comment in lib/devres.c.
>
> Thanks again!
>
next prev parent reply other threads:[~2014-11-05 13:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 20:45 [PATCH 0/2] iio: Add Cosmic Circuits ADC support Ezequiel Garcia
2014-10-29 20:45 ` [PATCH 1/2] iio: adc: Cosmic Circuits 10001 ADC driver Ezequiel Garcia
2014-10-31 17:19 ` Lars-Peter Clausen
2014-10-31 19:44 ` Lars-Peter Clausen
2014-11-04 23:29 ` Ezequiel Garcia
2014-11-05 13:35 ` Jonathan Cameron
2014-10-31 20:26 ` Peter Meerwald
2014-11-04 23:47 ` Ezequiel Garcia
2014-11-01 23:11 ` Hartmut Knaack
2014-11-04 23:41 ` Ezequiel Garcia
2014-11-05 13:41 ` Jonathan Cameron [this message]
2014-11-05 13:36 ` Jonathan Cameron
2014-10-29 20:45 ` [PATCH 2/2] DT: iio: adc: Add CC_10001 binding documentation Ezequiel Garcia
2014-11-05 13:40 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545A2901.1000802@kernel.org \
--to=jic23@kernel.org \
--cc=Naidu.Tellapati@imgtec.com \
--cc=Phani.Movva@imgtec.com \
--cc=abrestic@chromium.org \
--cc=ezequiel.garcia@imgtec.com \
--cc=james.hartley@imgtec.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox