* [PATCH] drivers:staging:iio: fix checkpatch complaint about space before comma
@ 2014-11-22 11:19 Zachary Warren
2014-11-22 11:23 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Zachary Warren @ 2014-11-22 11:19 UTC (permalink / raw)
To: jic23; +Cc: linux-iio, Zachary Warren
Fixes:
drivers/staging/iio/adc/ad7192.c:615: ERROR: space prohibited before that ','
drivers/staging/iio/meter/ade7759.c:119: ERROR: space prohibited before that ','
Signed-off-by: Zachary Warren <conflatulence@gmail.com>
---
This is for Eudyptula Challenge Task 10 which requires sending a checkpatch
fix in linux-next drivers/staging to a maintainer and public mailing list.
Apologies for mistakes and any inconvenience.
drivers/staging/iio/adc/ad7192.c | 2 +-
drivers/staging/iio/meter/ade7759.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
index f6526aa..6f8ce6c 100644
--- a/drivers/staging/iio/adc/ad7192.c
+++ b/drivers/staging/iio/adc/ad7192.c
@@ -612,7 +612,7 @@ static int ad7192_probe(struct spi_device *spi)
const struct ad7192_platform_data *pdata = spi->dev.platform_data;
struct ad7192_state *st;
struct iio_dev *indio_dev;
- int ret , voltage_uv = 0;
+ int ret, voltage_uv = 0;
if (!pdata) {
dev_err(&spi->dev, "no platform data?\n");
diff --git a/drivers/staging/iio/meter/ade7759.c b/drivers/staging/iio/meter/ade7759.c
index 7d21743..b0c7dbc 100644
--- a/drivers/staging/iio/meter/ade7759.c
+++ b/drivers/staging/iio/meter/ade7759.c
@@ -116,7 +116,7 @@ static int ade7759_spi_read_reg_40(struct device *dev,
mutex_lock(&st->buf_lock);
st->tx[0] = ADE7759_READ_REG(reg_address);
- memset(&st->tx[1], 0 , 5);
+ memset(&st->tx[1], 0, 5);
ret = spi_sync_transfer(st->us, xfers, ARRAY_SIZE(xfers));
if (ret) {
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers:staging:iio: fix checkpatch complaint about space before comma
2014-11-22 11:19 [PATCH] drivers:staging:iio: fix checkpatch complaint about space before comma Zachary Warren
@ 2014-11-22 11:23 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2014-11-22 11:23 UTC (permalink / raw)
To: Zachary Warren; +Cc: linux-iio
On 22/11/14 11:19, Zachary Warren wrote:
> Fixes:
> drivers/staging/iio/adc/ad7192.c:615: ERROR: space prohibited before that ','
> drivers/staging/iio/meter/ade7759.c:119: ERROR: space prohibited before that ','
>
> Signed-off-by: Zachary Warren <conflatulence@gmail.com>
Correctly formatted patch fixing a small issue - but, rare for for Eudyptula
patches, one that isn't just a matter of taste.
Nicely done. Applied to the togreg branch iio.git, initially pushed out
as testing because there is some other stuff in the tree that I'd like the
autobuilders to stomp all over before pushing a non rebasable patch out.
Thanks,
Jonathan
> ---
>
> This is for Eudyptula Challenge Task 10 which requires sending a checkpatch
> fix in linux-next drivers/staging to a maintainer and public mailing list.
> Apologies for mistakes and any inconvenience.
>
> drivers/staging/iio/adc/ad7192.c | 2 +-
> drivers/staging/iio/meter/ade7759.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index f6526aa..6f8ce6c 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -612,7 +612,7 @@ static int ad7192_probe(struct spi_device *spi)
> const struct ad7192_platform_data *pdata = spi->dev.platform_data;
> struct ad7192_state *st;
> struct iio_dev *indio_dev;
> - int ret , voltage_uv = 0;
> + int ret, voltage_uv = 0;
>
> if (!pdata) {
> dev_err(&spi->dev, "no platform data?\n");
> diff --git a/drivers/staging/iio/meter/ade7759.c b/drivers/staging/iio/meter/ade7759.c
> index 7d21743..b0c7dbc 100644
> --- a/drivers/staging/iio/meter/ade7759.c
> +++ b/drivers/staging/iio/meter/ade7759.c
> @@ -116,7 +116,7 @@ static int ade7759_spi_read_reg_40(struct device *dev,
>
> mutex_lock(&st->buf_lock);
> st->tx[0] = ADE7759_READ_REG(reg_address);
> - memset(&st->tx[1], 0 , 5);
> + memset(&st->tx[1], 0, 5);
>
> ret = spi_sync_transfer(st->us, xfers, ARRAY_SIZE(xfers));
> if (ret) {
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-22 11:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-22 11:19 [PATCH] drivers:staging:iio: fix checkpatch complaint about space before comma Zachary Warren
2014-11-22 11:23 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).