From: Richard Weinberger <richard@nod.at>
To: Harald Geyer <harald@ccbib.org>
Cc: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de,
pmeerw@pmeerw.net, sanjeev_sharma@mentor.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: iio: dht11 Updates
Date: Wed, 03 Dec 2014 23:05:25 +0100 [thread overview]
Message-ID: <547F8925.3050308@nod.at> (raw)
In-Reply-To: <E1XwAbX-0001Ht-Jg@stardust.g4.wien.funkfeuer.at>
Am 03.12.2014 um 15:08 schrieb Harald Geyer:
>> I was asking because I see the "dht11: WARNING: decoding ambiguous"
>> very often. (with and without my patches)
>
> Yes, your patches shouldn't have any effect on this.
> "very often" in the sense of "not always"? This would be very surprising,
> because this would involve variable length clock ticks, i think.
>
> I guess we should include timeres into the warning message.
>
> Also I guess now is the time to think about a smarter decoder.
Another question. Your driver defines:
#define DHT11_DATA_BIT_LOW 27000
#define DHT11_DATA_BIT_HIGH 70000
If I read the manual [0] correctly these constants are T_h0/1.
Why did you use 27000 for T_h0?
Setting it to 26000 (the typical value as stated by the manual),
I get the "decoding ambiguous" warning *always*. Setting it higher
makes the message go away.
Thanks,
//richard
[0] http://meteobox.tk/files/AM2302.pdf
next prev parent reply other threads:[~2014-12-03 22:05 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 23:32 iio: dht11 Updates Richard Weinberger
2014-12-02 23:32 ` [PATCH 1/4] iio: dht11: Add locking Richard Weinberger
2014-12-14 12:31 ` Hartmut Knaack
2014-12-14 14:06 ` Richard Weinberger
2014-12-02 23:32 ` [PATCH 2/4] iio: dht11: IRQ fixes Richard Weinberger
2014-12-02 23:35 ` Richard Weinberger
2014-12-06 17:21 ` harald
2014-12-02 23:32 ` [PATCH 3/4] iio: dht11: Logging updates Richard Weinberger
2014-12-03 12:58 ` Harald Geyer
2014-12-03 13:11 ` Richard Weinberger
2014-12-03 13:56 ` Harald Geyer
2014-12-03 21:30 ` Richard Weinberger
2014-12-04 14:25 ` Harald Geyer
2014-12-02 23:32 ` [PATCH 4/4] iio: dht11: Fix out-of-bounds read Richard Weinberger
2014-12-14 12:32 ` Hartmut Knaack
2014-12-03 12:18 ` iio: dht11 Updates Harald Geyer
2014-12-03 13:15 ` Richard Weinberger
2014-12-03 14:08 ` Harald Geyer
2014-12-03 14:29 ` Richard Weinberger
2014-12-03 22:05 ` Richard Weinberger [this message]
2014-12-04 13:45 ` Harald Geyer
2014-12-04 14:15 ` Richard Weinberger
2014-12-03 20:20 ` Richard Weinberger
2014-12-04 16:08 ` Harald Geyer
2015-01-01 12:38 ` Jonathan Cameron
2015-01-01 21:18 ` harald
2015-01-02 11:28 ` Richard Weinberger
2015-01-04 11:01 ` Jonathan Cameron
2015-01-05 13:49 ` [PATCHv2 1/3] iio: dht11: Fix out-of-bounds read Harald Geyer
2015-01-05 13:55 ` Richard Weinberger
2015-01-06 5:39 ` sanjeev sharma
2015-01-07 12:15 ` [PATCHv2 1/3,RESEND] " Harald Geyer
2015-01-10 11:14 ` Jonathan Cameron
2015-01-10 18:39 ` Richard Weinberger
2015-01-12 11:26 ` Harald Geyer
2015-01-12 11:27 ` Richard Weinberger
2015-01-07 12:18 ` [PATCHv2 2/3,RESEND] iio: dht11: Add locking Harald Geyer
2015-01-10 11:16 ` Jonathan Cameron
2015-02-22 10:44 ` Richard Weinberger
2015-02-25 12:01 ` Jonathan Cameron
2015-01-07 12:22 ` [PATCHv2 3/3,RESEND] iio: dht11: IRQ fixes Harald Geyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547F8925.3050308@nod.at \
--to=richard@nod.at \
--cc=harald@ccbib.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=sanjeev_sharma@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).