Linux IIO development
 help / color / mirror / Atom feed
From: Ezequiel Garcia <ezequiel.garcia@imgtec.com>
To: Jonathan Cameron <jic23@kernel.org>,
	James Hartley <james.hartley@imgtec.com>,
	Andrew Bresticker <abrestic@chromium.org>
Cc: <linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<robh+dt@kernel.org>, <Pawel.Moll@arm.com>,
	<Mark.Rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
	<galak@codeaurora.org>
Subject: Re: [PATCH v5 0/3] iio: Add Cosmic Circuits ADC support
Date: Fri, 5 Dec 2014 08:55:40 -0300	[thread overview]
Message-ID: <54819D3C.7000209@imgtec.com> (raw)
In-Reply-To: <1417102762-5123-1-git-send-email-ezequiel.garcia@imgtec.com>

Hi Jonathan,

On 11/27/2014 12:39 PM, Ezequiel Garcia wrote:
> Changes from v4:
> 
>   * Added a compile-time dependency on REGULATOR and HAVE_CLK.
> 
>   * Replaced the silly XOR operation for a proper mask out of the
>     available channels.
> 
> Changes from v3:
> 
>   * Fixed a few style nitpicks as per Hartmut's feedback.
> 
>   * Used GENMASK() to build the channel mask, which fixes a very nasty
>     bug. Also found by Hartmut.
> 
> Changes from v2:
> 
>   * Changed a devicetree property from adc-available-channels to
>     adc-reserved-channels, so it can be made optional.
> 
>   * Renamed the driver from cc_10001_xxx to cc10001_xxx so it's consistent
>     with the rest of the kernel style.
> 
>   * Some more minor cosmetic fixes.
> 
> Changes from v1:
> 
>   * Removed unneeded header includes.
> 
>   * Changed all the names and macros prefix: s/CC_10001_/CC10001_.
> 
>   * Used .update_scan_mode callback to preallocate the buffer.
> 
>   * Used indio_dev for the struct iio_dev.
> 
>   * Only read the regulator voltage when needed.
> 
>   * Fixed probe() error handling.
> 
>   * Used for_each_set_bit() instead of open-coding it.
> 
>   * Name the power-down register as _POWER_UP, to make the code
>     less silly.
> 
>   * Error out when no valid sample can be read (i.e. when end-of-conversion
>     poll times out).
> 
>   * ... plus some assorted code cleaning based on the feedback.
> 
> 
> Ezequiel Garcia (1):
>   DT: Add a vendor prefix for Cosmic Circuits
> 
> Phani Movva (2):
>   iio: adc: Cosmic Circuits 10001 ADC driver
>   DT: iio: adc: Add CC_10001 binding documentation
> 

Unless there are any outstanding issues with this series, it'd be great
to merge it for v3.19.

Thanks!
-- 
Ezequiel

  parent reply	other threads:[~2014-12-05 11:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-27 15:39 [PATCH v5 0/3] iio: Add Cosmic Circuits ADC support Ezequiel Garcia
2014-11-27 15:39 ` [PATCH v5 1/3] iio: adc: Cosmic Circuits 10001 ADC driver Ezequiel Garcia
2014-12-10 23:43   ` Hartmut Knaack
2014-12-11 15:21     ` Ezequiel Garcia
2014-11-27 15:39 ` [PATCH v5 2/3] DT: iio: adc: Add CC_10001 binding documentation Ezequiel Garcia
2014-11-27 15:39 ` [PATCH v5 3/3] DT: Add a vendor prefix for Cosmic Circuits Ezequiel Garcia
2014-12-05 11:55 ` Ezequiel Garcia [this message]
2014-12-05 13:12   ` [PATCH v5 0/3] iio: Add Cosmic Circuits ADC support Jonathan Cameron
2014-12-05 13:25     ` Jonathan Cameron
2014-12-05 14:33       ` Ezequiel Garcia
2014-12-06 14:56         ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54819D3C.7000209@imgtec.com \
    --to=ezequiel.garcia@imgtec.com \
    --cc=Mark.Rutland@arm.com \
    --cc=Pawel.Moll@arm.com \
    --cc=abrestic@chromium.org \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=james.hartley@imgtec.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox