From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailapp01.imgtec.com ([195.59.15.196]:6600 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750896AbaLEOe5 (ORCPT ); Fri, 5 Dec 2014 09:34:57 -0500 Message-ID: <5481C221.2040900@imgtec.com> Date: Fri, 5 Dec 2014 11:33:05 -0300 From: Ezequiel Garcia MIME-Version: 1.0 To: Jonathan Cameron , James Hartley , Andrew Bresticker CC: , , , , , , Subject: Re: [PATCH v5 0/3] iio: Add Cosmic Circuits ADC support References: <1417102762-5123-1-git-send-email-ezequiel.garcia@imgtec.com> <54819D3C.7000209@imgtec.com> <4C4CBD60-74E1-4A17-9D93-EDDE8AF33841@kernel.org> <5481B24B.4020507@kernel.org> In-Reply-To: <5481B24B.4020507@kernel.org> Content-Type: text/plain; charset="utf-8" Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 12/05/2014 10:25 AM, Jonathan Cameron wrote: > On 05/12/14 13:12, Jonathan Cameron wrote: >> >> >> On December 5, 2014 11:55:40 AM GMT+00:00, Ezequiel Garcia wrote: >>> Hi Jonathan, >>> >>> On 11/27/2014 12:39 PM, Ezequiel Garcia wrote: >>>> Changes from v4: >>>> >>>> * Added a compile-time dependency on REGULATOR and HAVE_CLK. >>>> >>>> * Replaced the silly XOR operation for a proper mask out of the >>>> available channels. >>>> >>>> Changes from v3: >>>> >>>> * Fixed a few style nitpicks as per Hartmut's feedback. >>>> >>>> * Used GENMASK() to build the channel mask, which fixes a very >>> nasty >>>> bug. Also found by Hartmut. >>>> >>>> Changes from v2: >>>> >>>> * Changed a devicetree property from adc-available-channels to >>>> adc-reserved-channels, so it can be made optional. >>>> >>>> * Renamed the driver from cc_10001_xxx to cc10001_xxx so it's >>> consistent >>>> with the rest of the kernel style. >>>> >>>> * Some more minor cosmetic fixes. >>>> >>>> Changes from v1: >>>> >>>> * Removed unneeded header includes. >>>> >>>> * Changed all the names and macros prefix: s/CC_10001_/CC10001_. >>>> >>>> * Used .update_scan_mode callback to preallocate the buffer. >>>> >>>> * Used indio_dev for the struct iio_dev. >>>> >>>> * Only read the regulator voltage when needed. >>>> >>>> * Fixed probe() error handling. >>>> >>>> * Used for_each_set_bit() instead of open-coding it. >>>> >>>> * Name the power-down register as _POWER_UP, to make the code >>>> less silly. >>>> >>>> * Error out when no valid sample can be read (i.e. when >>> end-of-conversion >>>> poll times out). >>>> >>>> * ... plus some assorted code cleaning based on the feedback. >>>> >>>> >>>> Ezequiel Garcia (1): >>>> DT: Add a vendor prefix for Cosmic Circuits >>>> >>>> Phani Movva (2): >>>> iio: adc: Cosmic Circuits 10001 ADC driver >>>> DT: iio: adc: Add CC_10001 binding documentation >>>> >>> >>> Unless there are any outstanding issues with this series, it'd be great >>> to merge it for v3.19. >>> >>> Thanks! >> Sorry too late unfortunately. Merge window opens on Sunday and stuff needs to have >> been in Greg KH's tree for a week before that. Going to be 3.20 now. >> Oh, shoot. I was hoping to be in time for the merge. Being a new driver there wasn't much harm in taking it earlier. > Also, the DT patch could really do with an Ack from Rob. If Hartmut/Lars > want to give a reviewed-by that would be good given they done the legwork > on reviewing your driver. > > Looks good to me btw. Just taken a quick look, but little gets past those > guys anyway :) > If at all possible, do you think you area able to pick the patches now (but you don't include them in your pull request to Linus) so they are linux-next? It'd be good to know they start getting build-test coverage soon. Thanks! -- Ezequiel