From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out-084.synserver.de ([212.40.185.84]:1103 "EHLO smtp-out-084.synserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966558AbaLMLZz (ORCPT ); Sat, 13 Dec 2014 06:25:55 -0500 Message-ID: <548C223B.6050905@metafoo.de> Date: Sat, 13 Dec 2014 12:25:47 +0100 From: Lars-Peter Clausen MIME-Version: 1.0 To: Hartmut Knaack , Nikolaus Schulz CC: Jonathan Cameron , Peter Meerwald , Grant Likely , Rob Herring , Michael Welling , Philippe Reynes , linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, Alban Bedel Subject: Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554 References: <1416858614-32265-1-git-send-email-nikolaus.schulz@avionic-design.de> <1416858614-32265-2-git-send-email-nikolaus.schulz@avionic-design.de> <5482EA33.7020305@gmx.de> <20141212155804.GA1142@avionic-0071.adnet.avionic-design.de> <548C209A.7000904@gmx.de> In-Reply-To: <548C209A.7000904@gmx.de> Content-Type: text/plain; charset=windows-1252; format=flowed Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 12/13/2014 12:18 PM, Hartmut Knaack wrote: [...] >>> According to your DT bindings, the regulator from property "vref-supply" should >>> be used. This is missing here. >> >> Uhm, it's right below, no? > Looking into your DT bindings patch (which unfortunately didn't make it into our > list), you specify "vref-supply" as a required property. So, I expected that you > intended to make use of this property somewhere around here. The regulator framework takes care of this. If you request a regulator with $name the framework will look for a property with the name $name-supply. >> >>>> + st->reg =evm_regulator_get(&spi->dev, "vref"); >>>> + if (IS_ERR(st->reg)) >>>> + return PTR_ERR(st->reg); [...]