From: Lars-Peter Clausen <lars@metafoo.de>
To: Nikolaus Schulz <nikolaus.schulz@avionic-design.de>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Michael Welling <mwelling@ieee.org>,
Philippe Reynes <tremyfr@yahoo.fr>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org
Cc: Alban Bedel <alban.bedel@avionic-design.de>
Subject: Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554
Date: Sat, 13 Dec 2014 12:29:57 +0100 [thread overview]
Message-ID: <548C2335.7080301@metafoo.de> (raw)
In-Reply-To: <1416858614-32265-2-git-send-email-nikolaus.schulz@avionic-design.de>
On 11/24/2014 08:50 PM, Nikolaus Schulz wrote:
[...]
> +const struct iio_chan_spec dac8554_channels[] = {
static
[...]
> + ret = of_property_read_u32(spi->dev.of_node, "address", &addr);
This should probably have vendor prefix.
> + if (ret || addr < 0 || addr > 2) {
> + dev_err(&spi->dev, "no or invalid chip address");
> + return -ENODEV;
> + }
next prev parent reply other threads:[~2014-12-13 11:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1416858614-32265-1-git-send-email-nikolaus.schulz@avionic-design.de>
2014-11-24 19:50 ` [PATCH v2 2/2] iio: add driver for the TI DAC8554 Nikolaus Schulz
2014-12-06 11:36 ` Hartmut Knaack
2014-12-12 11:57 ` Jonathan Cameron
2014-12-12 16:15 ` Nikolaus Schulz
2014-12-12 15:58 ` Nikolaus Schulz
2014-12-12 18:14 ` Jonathan Cameron
2014-12-13 11:18 ` Hartmut Knaack
2014-12-13 11:24 ` Hartmut Knaack
2014-12-13 11:25 ` Lars-Peter Clausen
2014-12-15 10:02 ` Nikolaus Schulz
2014-12-13 11:32 ` Lars-Peter Clausen
2014-12-13 11:29 ` Lars-Peter Clausen [this message]
2014-12-15 10:22 ` Nikolaus Schulz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548C2335.7080301@metafoo.de \
--to=lars@metafoo.de \
--cc=alban.bedel@avionic-design.de \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mwelling@ieee.org \
--cc=nikolaus.schulz@avionic-design.de \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=tremyfr@yahoo.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox