From: Lars-Peter Clausen <lars@metafoo.de>
To: Roberta Dobrescu <roberta.dobrescu@gmail.com>,
jic23@kernel.org, linux-iio@vger.kernel.org
Cc: octavian.purdila@intel.com, daniel.baluta@intel.com,
Michael.Hennerich@analog.com, knaack.h@gmx.de, pmeerw@pmeerw.net
Subject: Re: [PATCH 3/3] iio: frequency: Use usleep_range instead of msleep
Date: Thu, 18 Dec 2014 17:09:55 +0100 [thread overview]
Message-ID: <5492FC53.5000100@metafoo.de> (raw)
In-Reply-To: <1418721107-5429-4-git-send-email-roberta.dobrescu@gmail.com>
On 12/16/2014 10:11 AM, Roberta Dobrescu wrote:
> This patch fixes the following checkpatch.pl warning:
> WARNING: msleep < 20ms can sleep for up to 20ms
>
> Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
> ---
> drivers/iio/frequency/ad9523.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c
> index 7c5245d..2e41ca5 100644
> --- a/drivers/iio/frequency/ad9523.c
> +++ b/drivers/iio/frequency/ad9523.c
> @@ -445,7 +445,7 @@ static int ad9523_store_eeprom(struct iio_dev *indio_dev)
>
> tmp = 4;
> do {
> - msleep(16);
> + usleep_range(16000, 17000);
I don't think this is exactly timing critical, things will work fine if this
sleeps a bit longer. If you want to silence the warning for the sake of
silencing the warning, maybe just replace it with a msleep(20).
> ret = ad9523_read(indio_dev,
> AD9523_EEPROM_DATA_XFER_STATUS);
> if (ret < 0)
>
prev parent reply other threads:[~2014-12-18 16:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 9:11 [PATCH 0/3] iio: frequency: Fix checkpatch warnings Roberta Dobrescu
2014-12-16 9:11 ` [PATCH 1/3] iio: frequency: Remove 'out of memory' message Roberta Dobrescu
2014-12-16 11:22 ` Daniel Baluta
2014-12-18 16:14 ` Lars-Peter Clausen
2014-12-18 23:22 ` Hartmut Knaack
2014-12-23 8:51 ` Daniel Baluta
2014-12-23 9:07 ` Lars-Peter Clausen
2014-12-23 9:24 ` Daniel Baluta
2014-12-23 20:21 ` Hartmut Knaack
2014-12-23 21:46 ` Lars-Peter Clausen
2014-12-26 9:38 ` Jonathan Cameron
2014-12-16 9:11 ` [PATCH 2/3] iio: frequency: Remove unnecessary braces around single statement block Roberta Dobrescu
2014-12-16 11:23 ` Daniel Baluta
2014-12-18 16:13 ` Lars-Peter Clausen
2014-12-26 9:39 ` Jonathan Cameron
2014-12-16 9:11 ` [PATCH 3/3] iio: frequency: Use usleep_range instead of msleep Roberta Dobrescu
2014-12-18 16:09 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5492FC53.5000100@metafoo.de \
--to=lars@metafoo.de \
--cc=Michael.Hennerich@analog.com \
--cc=daniel.baluta@intel.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
--cc=octavian.purdila@intel.com \
--cc=pmeerw@pmeerw.net \
--cc=roberta.dobrescu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).