linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: jic23@kernel.org, linux-iio@vger.kernel.org,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [PATCH 3/3] iio: ak8975: Added autodetect feature for ACPI
Date: Thu, 18 Dec 2014 18:54:12 +0100	[thread overview]
Message-ID: <549314C4.8090001@metafoo.de> (raw)
In-Reply-To: <1418923812.4459.8.camel@spandruv-desktop.jf.intel.com>

On 12/18/2014 06:30 PM, Srinivas Pandruvada wrote:
> On Thu, 2014-12-18 at 18:05 +0100, Lars-Peter Clausen wrote:
>> On 12/18/2014 05:52 PM, Srinivas Pandruvada wrote:
>>> On Thu, 2014-12-18 at 17:28 +0100, Lars-Peter Clausen wrote:
>>>> Added I2C to Cc.
>>>>
>>>> On 12/15/2014 10:19 PM, Srinivas Pandruvada wrote:
>>>>> Using i2c auto detect feature and auto device creation feature,
>>>>> enumerate ak8975 device, by checking their presence.
>>>>> This is needed because when this device sits behind an i2c mux, there
>>>>> is no way to define i2c mux in ACPI. This will enable ak8975 on
>>>>> windows based tablets/laptops running Linux when connected via a mux.
>>>>> Since DT model already can define an i2c mux and devices connected to
>>>>> it, this feature is only enabled for ACPI.
>>>>>
>>>>
>>>> This is quite a bit of a hack.
>>> Why?
>>> Auto detect is standard feature of i2c devices. This is using standard
>>> auto detect feature provided by the framework.
>>
>> Auto detect is ugly, slow and unreliable, it's kind of like the last straw
>> if nothing else works.
> That is true here. You can't enumerate this device by ACPI. As discussed
> before we created i2c mux in inv6050 so that we can use AK8975 in bypass
> mode. I added some API to create i2c device on this mux, which Wolfram
> didn't like. He wanted to enumerate using existing mechanisms.

If there is only a single ACPI ID that says this is a INV6050 with a AK8975 
attached then the way to handle this is to have a driver that binds to that id 
and creates both devices.

- Lars

  reply	other threads:[~2014-12-18 17:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-15 21:19 [PATCH 0/3] Enable AK8963 conneted via INV6500 Srinivas Pandruvada
2014-12-15 21:19 ` [PATCH 1/3] iio: imu: inv_mpu6050: ACPI enumeration Srinivas Pandruvada
2014-12-26 12:39   ` Jonathan Cameron
2014-12-15 21:19 ` [PATCH 2/3] iio: imu: inv_mpu6050: Added adapter class Srinivas Pandruvada
2014-12-26 12:37   ` Jonathan Cameron
2014-12-31 10:25     ` Wolfram Sang
2015-01-01 12:27       ` Jonathan Cameron
2015-01-04 19:20       ` Jean Delvare
2014-12-15 21:19 ` [PATCH 3/3] iio: ak8975: Added autodetect feature for ACPI Srinivas Pandruvada
2014-12-18 16:28   ` Lars-Peter Clausen
2014-12-18 16:52     ` Srinivas Pandruvada
2014-12-18 17:05       ` Lars-Peter Clausen
2014-12-18 17:30         ` Srinivas Pandruvada
2014-12-18 17:54           ` Lars-Peter Clausen [this message]
2014-12-18 18:00             ` Srinivas Pandruvada
2014-12-26 11:53               ` Jonathan Cameron
2015-01-08 16:40                 ` Wolfram Sang
2015-01-08 16:54                   ` Srinivas Pandruvada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=549314C4.8090001@metafoo.de \
    --to=lars@metafoo.de \
    --cc=jic23@kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).