linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: "Arnaud Ebalard" <arno@natisbad.org>,
	"Hartmut Knaack" <knaack.h@gmx.de>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Peter Meerwald" <pmeerw@pmeerw.net>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Darshana Padmadas" <darshanapadmadas@gmail.com>,
	linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Uwe Kleine-König" <uwe@kleine-koenig.org>
Subject: Re: [PATCHv2 5/8] staging: iio: isl29028: deprecate use of isl in compatible string for isil
Date: Fri, 26 Dec 2014 12:06:08 +0000	[thread overview]
Message-ID: <549D4F30.4000904@kernel.org> (raw)
In-Reply-To: <f935306404d9b6d8a37862987122b6988cb6ffff.1418763328.git.arno@natisbad.org>

On 16/12/14 21:20, Arnaud Ebalard wrote:
> 
> "isil" and "isl" prefixes are used at various locations inside the kernel
> to reference Intersil corporation. This patch is part of a series fixing
> those locations were "isl" is used in compatible strings to use the now
> expected "isil" prefix instead (NASDAQ symbol for Intersil and most used
> version). The old compatible string is kept for backward compatibility.
> 
> Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
This is getting a little silly. 

I'll go with whatever the device tree maintainers decide. Hence if they are happy,
Acked-by: Jonathan Cameron <jic23@kernel.org>
> ---
>  drivers/staging/iio/light/isl29028.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c
> index e969107ddb47..6440e3b293ca 100644
> --- a/drivers/staging/iio/light/isl29028.c
> +++ b/drivers/staging/iio/light/isl29028.c
> @@ -537,8 +537,8 @@ static const struct i2c_device_id isl29028_id[] = {
>  MODULE_DEVICE_TABLE(i2c, isl29028_id);
>  
>  static const struct of_device_id isl29028_of_match[] = {
> -	{ .compatible = "isl,isl29028", },
> -	{ .compatible = "isil,isl29028", },/* deprecated, don't use */
> +	{ .compatible = "isl,isl29028", }, /* for backward compat., don't use */
> +	{ .compatible = "isil,isl29028", },
>  	{ },
>  };
>  MODULE_DEVICE_TABLE(of, isl29028_of_match);
> 


      reply	other threads:[~2014-12-26 12:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-16 21:18 [PATCHv2 0/8] from now on, use 'isil' as prefix for Intersil Arnaud Ebalard
2014-12-16 21:20 ` [PATCHv2 5/8] staging: iio: isl29028: deprecate use of isl in compatible string for isil Arnaud Ebalard
2014-12-26 12:06   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=549D4F30.4000904@kernel.org \
    --to=jic23@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=arno@natisbad.org \
    --cc=darshanapadmadas@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pmeerw@pmeerw.net \
    --cc=uwe@kleine-koenig.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).