From: Jonathan Cameron <jic23@kernel.org>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: kristina.martsenko@gmail.com, kernel@pengutronix.de,
pawel.moll@arm.com, knaack.h@gmx.de,
ijc+devicetree@hellion.org.uk, robh+dt@kernel.org,
galak@codeaurora.org, festevam@gmail.com, mark.rutland@arm.com,
linux-iio@vger.kernel.org, marex@denx.de,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: mxs-lradc: check ranges of ts properties
Date: Fri, 26 Dec 2014 21:57:20 +0000 [thread overview]
Message-ID: <549DD9C0.3020100@kernel.org> (raw)
In-Reply-To: <1377154085.658607.1419627037868.JavaMail.open-xchange@oxbaltgw05.schlund.de>
On 26/12/14 20:50, Stefan Wahren wrote:
> Hi Jonathan,
>
>> Jonathan Cameron <jic23@kernel.org> hat am 26. Dezember 2014 um 10:23
>> geschrieben:
>>
>> [...]
>>>
>>> - lradc->over_sample_delay = 2;
>>> - ret = of_property_read_u32(lradc_node, "fsl,ave-delay", &adapt);
>>> - if (ret == 0)
>>> + if (of_property_read_u32(lradc_node, "fsl,ave-delay", &adapt)) {
>>> + lradc->over_sample_delay = 2;
>>> + } else {
>>> + if (adapt < 2 || adapt > LRADC_DELAY_DELAY_MASK+1) {
>> please run checkpatch.pl over these. Should be spaces around the +
>
> i'm afraid my checkpatch.pl doesn't find this issue. I'll fix it in the next
> version.
>
So it doesn't! Sorry about the false comment.
Hmm. I wonder why...
prev parent reply other threads:[~2014-12-26 21:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-22 12:14 [PATCH 0/2] iio: mxs-lradc: check ranges of ts properties Stefan Wahren
2014-12-22 12:14 ` [PATCH 1/2] DT: mxs-lradc: fix " Stefan Wahren
2014-12-22 12:14 ` [PATCH 2/2] iio: mxs-lradc: check " Stefan Wahren
2014-12-23 13:37 ` Marek Vasut
2014-12-23 22:45 ` Stefan Wahren
2014-12-24 0:35 ` Marek Vasut
2014-12-26 9:22 ` Jonathan Cameron
2014-12-26 9:23 ` Jonathan Cameron
2014-12-26 20:50 ` Stefan Wahren
2014-12-26 21:57 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=549DD9C0.3020100@kernel.org \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=knaack.h@gmx.de \
--cc=kristina.martsenko@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=marex@denx.de \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).