[PATCH 0/3] iio: accel: Fix checkpatch warnings

[PATCH 0/3] iio: accel: Fix checkpatch warnings

[Roberta Dobrescu]

This patchset fixes warnings detected using checkpatch.pl,
such as: missing blank line after declarations, trailing whitespaces,
incomplete config symbol description.

Roberta Dobrescu (3):
  iio: accel: kxcjk-1013: Add a blank line after declarations
  iio: accel: mma8452: Remove trailing whitespace
  iio: accel: Annotate Kconfig entries with module name information

 drivers/iio/accel/Kconfig      | 6 ++++++
 drivers/iio/accel/kxcjk-1013.c | 1 +
 drivers/iio/accel/mma8452.c    | 2 +-
 3 files changed, 8 insertions(+), 1 deletion(-)

-- 
1.9.1

[PATCH 1/3] iio: accel: kxcjk-1013: Add a blank line after declarations

[Roberta Dobrescu]

This patch fixes the following checkpatch.pl warning:
WARNING: Missing a blank line after declarations

Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
---
 drivers/iio/accel/kxcjk-1013.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
index da2fe93..b3a2da5 100644
--- a/drivers/iio/accel/kxcjk-1013.c
+++ b/drivers/iio/accel/kxcjk-1013.c
@@ -1134,6 +1134,7 @@ static const char *kxcjk1013_match_acpi_device(struct device *dev,
 					       enum kx_chipset *chipset)
 {
 	const struct acpi_device_id *id;
+
 	id = acpi_match_device(dev->driver->acpi_match_table, dev);
 	if (!id)
 		return NULL;
-- 
1.9.1

[PATCH 2/3] iio: accel: mma8452: Remove trailing whitespace

[Roberta Dobrescu]

This patch fixes the following checkpatch.pl error:
ERROR: trailing whitespace

Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
---
 drivers/iio/accel/mma8452.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
index 3c12d49..5b80657 100644
--- a/drivers/iio/accel/mma8452.c
+++ b/drivers/iio/accel/mma8452.c
@@ -111,7 +111,7 @@ static const int mma8452_samp_freq[8][2] = {
 	{6, 250000}, {1, 560000}
 };
 
-/* 
+/*
  * Hardware has fullscale of -2G, -4G, -8G corresponding to raw value -2048
  * The userspace interface uses m/s^2 and we declare micro units
  * So scale factor is given by:
-- 
1.9.1

[PATCH 3/3] iio: accel: Annotate Kconfig entries with module name information

[Roberta Dobrescu]

This patch fixes the following checkpatch.pl warning:
WARNING: please write a paragraph that describes the config symbol fully

Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
---
 drivers/iio/accel/Kconfig | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/iio/accel/Kconfig b/drivers/iio/accel/Kconfig
index 9b9be87..402a3a5 100644
--- a/drivers/iio/accel/Kconfig
+++ b/drivers/iio/accel/Kconfig
@@ -43,6 +43,9 @@ config HID_SENSOR_ACCEL_3D
 	  Say yes here to build support for the HID SENSOR
 	  accelerometers 3D.
 
+	  To compile this driver as a module, choose M here: the
+	  module will be called hid-sensor-accel-3d.
+
 config IIO_ST_ACCEL_3AXIS
 	tristate "STMicroelectronics accelerometers 3-Axis Driver"
 	depends on (I2C || SPI_MASTER) && SYSFS
@@ -80,6 +83,9 @@ config KXSD9
 	  Say yes here to build support for the Kionix KXSD9 accelerometer.
 	  Currently this only supports the device via an SPI interface.
 
+	  To compile this driver as a module, choose M here: the module
+	  will be called kxsd9.
+
 config MMA8452
 	tristate "Freescale MMA8452Q Accelerometer Driver"
 	depends on I2C
-- 
1.9.1

Re: [PATCH 1/3] iio: accel: kxcjk-1013: Add a blank line after declarations

[Jonathan Cameron]

On 30/12/14 18:57, Roberta Dobrescu wrote:
> This patch fixes the following checkpatch.pl warning:
> WARNING: Missing a blank line after declarations
> 
> Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Applied to the togreg branch of iio.git - initially pushed out
as testing for the autobuilders to play.

Thanks,

Jonathan
> ---
>  drivers/iio/accel/kxcjk-1013.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
> index da2fe93..b3a2da5 100644
> --- a/drivers/iio/accel/kxcjk-1013.c
> +++ b/drivers/iio/accel/kxcjk-1013.c
> @@ -1134,6 +1134,7 @@ static const char *kxcjk1013_match_acpi_device(struct device *dev,
>  					       enum kx_chipset *chipset)
>  {
>  	const struct acpi_device_id *id;
> +
>  	id = acpi_match_device(dev->driver->acpi_match_table, dev);
>  	if (!id)
>  		return NULL;
> 

Re: [PATCH 2/3] iio: accel: mma8452: Remove trailing whitespace

[Jonathan Cameron]

On 30/12/14 18:57, Roberta Dobrescu wrote:
> This patch fixes the following checkpatch.pl error:
> ERROR: trailing whitespace
> 
> Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Applied to the togreg branch of iio.git.

Thanks
> ---
>  drivers/iio/accel/mma8452.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
> index 3c12d49..5b80657 100644
> --- a/drivers/iio/accel/mma8452.c
> +++ b/drivers/iio/accel/mma8452.c
> @@ -111,7 +111,7 @@ static const int mma8452_samp_freq[8][2] = {
>  	{6, 250000}, {1, 560000}
>  };
>  
> -/* 
> +/*
>   * Hardware has fullscale of -2G, -4G, -8G corresponding to raw value -2048
>   * The userspace interface uses m/s^2 and we declare micro units
>   * So scale factor is given by:
> 

Re: [PATCH 3/3] iio: accel: Annotate Kconfig entries with module name information

[Jonathan Cameron]

On 30/12/14 18:57, Roberta Dobrescu wrote:
> This patch fixes the following checkpatch.pl warning:
> WARNING: please write a paragraph that describes the config symbol fully
> 
> Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Applied to the togreg branch of iio.git.

Thanks,
> ---
>  drivers/iio/accel/Kconfig | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/iio/accel/Kconfig b/drivers/iio/accel/Kconfig
> index 9b9be87..402a3a5 100644
> --- a/drivers/iio/accel/Kconfig
> +++ b/drivers/iio/accel/Kconfig
> @@ -43,6 +43,9 @@ config HID_SENSOR_ACCEL_3D
>  	  Say yes here to build support for the HID SENSOR
>  	  accelerometers 3D.
>  
> +	  To compile this driver as a module, choose M here: the
> +	  module will be called hid-sensor-accel-3d.
> +
>  config IIO_ST_ACCEL_3AXIS
>  	tristate "STMicroelectronics accelerometers 3-Axis Driver"
>  	depends on (I2C || SPI_MASTER) && SYSFS
> @@ -80,6 +83,9 @@ config KXSD9
>  	  Say yes here to build support for the Kionix KXSD9 accelerometer.
>  	  Currently this only supports the device via an SPI interface.
>  
> +	  To compile this driver as a module, choose M here: the module
> +	  will be called kxsd9.
> +
>  config MMA8452
>  	tristate "Freescale MMA8452Q Accelerometer Driver"
>  	depends on I2C
>