* [PATCH 0/2] Fix checkpatch warnings
@ 2014-12-30 18:48 Roberta Dobrescu
2014-12-30 18:48 ` [PATCH 1/2] iio: light: Annotate Kconfig entry with module name information Roberta Dobrescu
2014-12-30 18:48 ` [PATCH 2/2] iio: light: lm3533-als: Remove space before ',' Roberta Dobrescu
0 siblings, 2 replies; 5+ messages in thread
From: Roberta Dobrescu @ 2014-12-30 18:48 UTC (permalink / raw)
To: jic23, linux-iio
Cc: octavian.purdila, daniel.baluta, lars, Michael.Hennerich,
knaack.h, pmeerw, Roberta Dobrescu
This patchset fixes warnings detected using checkpatch.pl,
such as: incomplete config symbol description, prohibited
space before ','.
Roberta Dobrescu (2):
iio: light: Annotate Kconfig entry with module name information
iio: light: lm3533-als: Remove space before ','
drivers/iio/light/Kconfig | 3 +++
drivers/iio/light/lm3533-als.c | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
--
1.9.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] iio: light: Annotate Kconfig entry with module name information
2014-12-30 18:48 [PATCH 0/2] Fix checkpatch warnings Roberta Dobrescu
@ 2014-12-30 18:48 ` Roberta Dobrescu
2015-01-01 12:14 ` Jonathan Cameron
2014-12-30 18:48 ` [PATCH 2/2] iio: light: lm3533-als: Remove space before ',' Roberta Dobrescu
1 sibling, 1 reply; 5+ messages in thread
From: Roberta Dobrescu @ 2014-12-30 18:48 UTC (permalink / raw)
To: jic23, linux-iio
Cc: octavian.purdila, daniel.baluta, lars, Michael.Hennerich,
knaack.h, pmeerw, Roberta Dobrescu
This patch fixes the following checkpatch.pl warning:
WARNING: please write a paragraph that describes the config symbol fully
Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
---
drivers/iio/light/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig
index 5bea821..fce4d688 100644
--- a/drivers/iio/light/Kconfig
+++ b/drivers/iio/light/Kconfig
@@ -95,6 +95,9 @@ config HID_SENSOR_ALS
Say yes here to build support for the HID SENSOR
Ambient light sensor.
+ To compile this driver as a module, choose M here: the
+ module will be called hid-sensor-als.
+
config HID_SENSOR_PROX
depends on HID_SENSOR_HUB
select IIO_BUFFER
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] iio: light: lm3533-als: Remove space before ','
2014-12-30 18:48 [PATCH 0/2] Fix checkpatch warnings Roberta Dobrescu
2014-12-30 18:48 ` [PATCH 1/2] iio: light: Annotate Kconfig entry with module name information Roberta Dobrescu
@ 2014-12-30 18:48 ` Roberta Dobrescu
2015-01-01 12:14 ` Jonathan Cameron
1 sibling, 1 reply; 5+ messages in thread
From: Roberta Dobrescu @ 2014-12-30 18:48 UTC (permalink / raw)
To: jic23, linux-iio
Cc: octavian.purdila, daniel.baluta, lars, Michael.Hennerich,
knaack.h, pmeerw, Roberta Dobrescu
This patch fixes the following checkpatch.pl error:
ERROR: space prohibited before that ',' (ctx:WxE)
Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
---
drivers/iio/light/lm3533-als.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c
index ae3c71b..076bc46 100644
--- a/drivers/iio/light/lm3533-als.c
+++ b/drivers/iio/light/lm3533-als.c
@@ -657,7 +657,7 @@ static ALS_HYSTERESIS_ATTR_RO(3);
#define ILLUMINANCE_ATTR_RO(_name) \
DEVICE_ATTR(in_illuminance0_##_name, S_IRUGO, show_##_name, NULL)
#define ILLUMINANCE_ATTR_RW(_name) \
- DEVICE_ATTR(in_illuminance0_##_name, S_IRUGO | S_IWUSR , \
+ DEVICE_ATTR(in_illuminance0_##_name, S_IRUGO | S_IWUSR, \
show_##_name, store_##_name)
/*
* ALS Zone threshold-event enable
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] iio: light: Annotate Kconfig entry with module name information
2014-12-30 18:48 ` [PATCH 1/2] iio: light: Annotate Kconfig entry with module name information Roberta Dobrescu
@ 2015-01-01 12:14 ` Jonathan Cameron
0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2015-01-01 12:14 UTC (permalink / raw)
To: Roberta Dobrescu, linux-iio
Cc: octavian.purdila, daniel.baluta, lars, Michael.Hennerich,
knaack.h, pmeerw
On 30/12/14 18:48, Roberta Dobrescu wrote:
> This patch fixes the following checkpatch.pl warning:
> WARNING: please write a paragraph that describes the config symbol fully
>
> Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Applied.
> ---
> drivers/iio/light/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig
> index 5bea821..fce4d688 100644
> --- a/drivers/iio/light/Kconfig
> +++ b/drivers/iio/light/Kconfig
> @@ -95,6 +95,9 @@ config HID_SENSOR_ALS
> Say yes here to build support for the HID SENSOR
> Ambient light sensor.
>
> + To compile this driver as a module, choose M here: the
> + module will be called hid-sensor-als.
> +
> config HID_SENSOR_PROX
> depends on HID_SENSOR_HUB
> select IIO_BUFFER
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] iio: light: lm3533-als: Remove space before ','
2014-12-30 18:48 ` [PATCH 2/2] iio: light: lm3533-als: Remove space before ',' Roberta Dobrescu
@ 2015-01-01 12:14 ` Jonathan Cameron
0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2015-01-01 12:14 UTC (permalink / raw)
To: Roberta Dobrescu, linux-iio
Cc: octavian.purdila, daniel.baluta, lars, Michael.Hennerich,
knaack.h, pmeerw
On 30/12/14 18:48, Roberta Dobrescu wrote:
> This patch fixes the following checkpatch.pl error:
> ERROR: space prohibited before that ',' (ctx:WxE)
>
> Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Applied.
> ---
> drivers/iio/light/lm3533-als.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c
> index ae3c71b..076bc46 100644
> --- a/drivers/iio/light/lm3533-als.c
> +++ b/drivers/iio/light/lm3533-als.c
> @@ -657,7 +657,7 @@ static ALS_HYSTERESIS_ATTR_RO(3);
> #define ILLUMINANCE_ATTR_RO(_name) \
> DEVICE_ATTR(in_illuminance0_##_name, S_IRUGO, show_##_name, NULL)
> #define ILLUMINANCE_ATTR_RW(_name) \
> - DEVICE_ATTR(in_illuminance0_##_name, S_IRUGO | S_IWUSR , \
> + DEVICE_ATTR(in_illuminance0_##_name, S_IRUGO | S_IWUSR, \
> show_##_name, store_##_name)
> /*
> * ALS Zone threshold-event enable
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-01-01 12:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-30 18:48 [PATCH 0/2] Fix checkpatch warnings Roberta Dobrescu
2014-12-30 18:48 ` [PATCH 1/2] iio: light: Annotate Kconfig entry with module name information Roberta Dobrescu
2015-01-01 12:14 ` Jonathan Cameron
2014-12-30 18:48 ` [PATCH 2/2] iio: light: lm3533-als: Remove space before ',' Roberta Dobrescu
2015-01-01 12:14 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).