linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Roberta Dobrescu <roberta.dobrescu@gmail.com>, linux-iio@vger.kernel.org
Cc: octavian.purdila@intel.com, daniel.baluta@intel.com,
	lars@metafoo.de, Michael.Hennerich@analog.com, knaack.h@gmx.de,
	pmeerw@pmeerw.net
Subject: Re: [PATCH v2] iio: frequency: ad9523: Increase sleep time in ad9523_store_eeprom
Date: Thu, 01 Jan 2015 12:19:17 +0000	[thread overview]
Message-ID: <54A53B45.7080007@kernel.org> (raw)
In-Reply-To: <1419965074-3929-1-git-send-email-roberta.dobrescu@gmail.com>

On 30/12/14 18:44, Roberta Dobrescu wrote:
> This patch increases sleep time in ad9523_store_eeprom to 20ms since
> it isn't timing critical. It fixes the following checkpatch.pl warning:
> WARNING: msleep < 20ms can sleep for up to 20ms
> 
> Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Applied to the togreg branch of iio.git - initially pushed out as testing
for the autobuilders to play.
> ---
> Changes since v1:
> 	* Increase sleep time in msleep instead of using usleep_range
> 	* Change subject and commit message accordingly
> 
>  drivers/iio/frequency/ad9523.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c
> index 7c5245d..50ed8d1 100644
> --- a/drivers/iio/frequency/ad9523.c
> +++ b/drivers/iio/frequency/ad9523.c
> @@ -445,7 +445,7 @@ static int ad9523_store_eeprom(struct iio_dev *indio_dev)
>  
>  	tmp = 4;
>  	do {
> -		msleep(16);
> +		msleep(20);
>  		ret = ad9523_read(indio_dev,
>  				  AD9523_EEPROM_DATA_XFER_STATUS);
>  		if (ret < 0)
> 


      reply	other threads:[~2015-01-01 12:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-30 18:44 [PATCH v2] iio: frequency: ad9523: Increase sleep time in ad9523_store_eeprom Roberta Dobrescu
2015-01-01 12:19 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54A53B45.7080007@kernel.org \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=daniel.baluta@intel.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=octavian.purdila@intel.com \
    --cc=pmeerw@pmeerw.net \
    --cc=roberta.dobrescu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).