From: Jonathan Cameron <jic23@kernel.org>
To: Vlad Dogaru <vlad.dogaru@intel.com>, linux-iio@vger.kernel.org
Subject: Re: [PATCH] staging: iio: dummy: fix compile error when not using buffering
Date: Thu, 01 Jan 2015 12:21:15 +0000 [thread overview]
Message-ID: <54A53BBB.20402@kernel.org> (raw)
In-Reply-To: <1419846616-31441-1-git-send-email-vlad.dogaru@intel.com>
On 29/12/14 09:50, Vlad Dogaru wrote:
> Commit 4ae03019923f ("staging:iio:dummy: Register same channels for
> device and buffer") has changed the number of parameters for
> iio_simple_dummy_configure_buffer() only for the IIO_SIMPLE_DUMMY_BUFFER
> case. Fix this by also changing the placeholder function declared in
> the header when buffering is not enabled.
>
> Signed-off-by: Vlad Dogaru <vlad.dogaru@intel.com>
Good catch - clears up an autobuilder warning I'd been meaning to chase down as well.
Thanks,
> ---
> drivers/staging/iio/iio_simple_dummy.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/iio_simple_dummy.h b/drivers/staging/iio/iio_simple_dummy.h
> index af70126..34989bf 100644
> --- a/drivers/staging/iio/iio_simple_dummy.h
> +++ b/drivers/staging/iio/iio_simple_dummy.h
> @@ -117,8 +117,7 @@ enum iio_simple_dummy_scan_elements {
> int iio_simple_dummy_configure_buffer(struct iio_dev *indio_dev);
> void iio_simple_dummy_unconfigure_buffer(struct iio_dev *indio_dev);
> #else
> -static inline int iio_simple_dummy_configure_buffer(struct iio_dev *indio_dev,
> - const struct iio_chan_spec *channels, unsigned int num_channels)
> +static inline int iio_simple_dummy_configure_buffer(struct iio_dev *indio_dev)
> {
> return 0;
> };
>
prev parent reply other threads:[~2015-01-01 12:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-29 9:50 [PATCH] staging: iio: dummy: fix compile error when not using buffering Vlad Dogaru
2015-01-01 12:21 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54A53BBB.20402@kernel.org \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=vlad.dogaru@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).