[PATCH] staging: iio: dummy: fix compile error when not using buffering

[PATCH] staging: iio: dummy: fix compile error when not using buffering

[Vlad Dogaru]

Commit 4ae03019923f ("staging:iio:dummy: Register same channels for
device and buffer") has changed the number of parameters for
iio_simple_dummy_configure_buffer() only for the IIO_SIMPLE_DUMMY_BUFFER
case.  Fix this by also changing the placeholder function declared in
the header when buffering is not enabled.

Signed-off-by: Vlad Dogaru <vlad.dogaru@intel.com>
---
 drivers/staging/iio/iio_simple_dummy.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/iio/iio_simple_dummy.h b/drivers/staging/iio/iio_simple_dummy.h
index af70126..34989bf 100644
--- a/drivers/staging/iio/iio_simple_dummy.h
+++ b/drivers/staging/iio/iio_simple_dummy.h
@@ -117,8 +117,7 @@ enum iio_simple_dummy_scan_elements {
 int iio_simple_dummy_configure_buffer(struct iio_dev *indio_dev);
 void iio_simple_dummy_unconfigure_buffer(struct iio_dev *indio_dev);
 #else
-static inline int iio_simple_dummy_configure_buffer(struct iio_dev *indio_dev,
-	const struct iio_chan_spec *channels, unsigned int num_channels)
+static inline int iio_simple_dummy_configure_buffer(struct iio_dev *indio_dev)
 {
 	return 0;
 };
-- 
1.9.1

Re: [PATCH] staging: iio: dummy: fix compile error when not using buffering

[Jonathan Cameron]

On 29/12/14 09:50, Vlad Dogaru wrote:
> Commit 4ae03019923f ("staging:iio:dummy: Register same channels for
> device and buffer") has changed the number of parameters for
> iio_simple_dummy_configure_buffer() only for the IIO_SIMPLE_DUMMY_BUFFER
> case.  Fix this by also changing the placeholder function declared in
> the header when buffering is not enabled.
> 
> Signed-off-by: Vlad Dogaru <vlad.dogaru@intel.com>
Good catch - clears up an autobuilder warning I'd been meaning to chase down as well.

Thanks,

> ---
>  drivers/staging/iio/iio_simple_dummy.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/iio_simple_dummy.h b/drivers/staging/iio/iio_simple_dummy.h
> index af70126..34989bf 100644
> --- a/drivers/staging/iio/iio_simple_dummy.h
> +++ b/drivers/staging/iio/iio_simple_dummy.h
> @@ -117,8 +117,7 @@ enum iio_simple_dummy_scan_elements {
>  int iio_simple_dummy_configure_buffer(struct iio_dev *indio_dev);
>  void iio_simple_dummy_unconfigure_buffer(struct iio_dev *indio_dev);
>  #else
> -static inline int iio_simple_dummy_configure_buffer(struct iio_dev *indio_dev,
> -	const struct iio_chan_spec *channels, unsigned int num_channels)
> +static inline int iio_simple_dummy_configure_buffer(struct iio_dev *indio_dev)
>  {
>  	return 0;
>  };
>