From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:48245 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751753AbbADLGk (ORCPT ); Sun, 4 Jan 2015 06:06:40 -0500 Message-ID: <54A91EBE.9030608@kernel.org> Date: Sun, 04 Jan 2015 11:06:38 +0000 From: Jonathan Cameron MIME-Version: 1.0 To: Devendra Naga , Lars-Peter Clausen , Michael Hennerich , Hartmut Knaack , Peter Meerwald , Greg Kroah-Hartman , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCH V2 1/2] iio: meter: ade7754: add error handling in _reset and _stop_device References: <1420189375-19854-1-git-send-email-devendra.aaru@gmail.com> In-Reply-To: <1420189375-19854-1-git-send-email-devendra.aaru@gmail.com> Content-Type: text/plain; charset=utf-8 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 02/01/15 09:02, Devendra Naga wrote: > This patch adds the error handling for the value returned from > ade7754_spi_read_reg_8. With this patch, the following randconfig > warnings get fixed automatically. > > drivers/staging/iio/meter/ade7754.c:222:6: warning: ‘val’ may be used > uninitialized in this function [-Wmaybe-uninitialized] > drivers/staging/iio/meter/ade7754.c:368:6: warning: ‘val’ may be used > uninitialized in this function [-Wmaybe-uninitialized] > > Signed-off-by: Devendra Naga Looks good to me. A Hartmut reviewed the original patch I'll leave it a few days to see if he wants to take a look at the update. Thanks, Jonathan > --- > > Hello, > > Please see if this is the error message you wanted. > > Build tested on next-20141231 with randconfig sent to iio ml, > and with allmodconfig. > > drivers/staging/iio/meter/ade7754.c | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/iio/meter/ade7754.c b/drivers/staging/iio/meter/ade7754.c > index 81f6731..746b188 100644 > --- a/drivers/staging/iio/meter/ade7754.c > +++ b/drivers/staging/iio/meter/ade7754.c > @@ -216,9 +216,13 @@ error_ret: > > static int ade7754_reset(struct device *dev) > { > + int ret; > u8 val; > > - ade7754_spi_read_reg_8(dev, ADE7754_OPMODE, &val); > + ret = ade7754_spi_read_reg_8(dev, ADE7754_OPMODE, &val); > + if (ret < 0) > + return ret; > + > val |= 1 << 6; /* Software Chip Reset */ > return ade7754_spi_write_reg_8(dev, ADE7754_OPMODE, val); > } > @@ -362,9 +366,16 @@ error_ret: > /* Power down the device */ > static int ade7754_stop_device(struct device *dev) > { > + int ret; > u8 val; > > - ade7754_spi_read_reg_8(dev, ADE7754_OPMODE, &val); > + ret = ade7754_spi_read_reg_8(dev, ADE7754_OPMODE, &val); > + if (ret < 0) { > + dev_err(dev, "unable to power down the device, error: %d", > + ret); > + return ret; > + } > + > val |= 7 << 3; /* ADE7754 powered down */ > return ade7754_spi_write_reg_8(dev, ADE7754_OPMODE, val); > } >