From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com ([192.55.52.115]:23946 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751541AbbAEIz3 (ORCPT ); Mon, 5 Jan 2015 03:55:29 -0500 Message-ID: <54AA51F0.20706@intel.com> Date: Mon, 05 Jan 2015 10:57:20 +0200 From: Daniel Baluta MIME-Version: 1.0 To: Jonathan Cameron , Hartmut Knaack CC: lars@metafoo.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, srinivas.pandruvada@linux.intel.com Subject: Re: [PATCH 03/10] iio: imu: kmx61: Enhance error handling References: <1419340953-23161-1-git-send-email-daniel.baluta@intel.com> <1419340953-23161-4-git-send-email-daniel.baluta@intel.com> <54A54FE2.1020407@gmx.de> <54A919D5.2000408@kernel.org> In-Reply-To: <54A919D5.2000408@kernel.org> Content-Type: text/plain; charset=windows-1252; format=flowed Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 01/04/2015 12:45 PM, Jonathan Cameron wrote: > On 01/01/15 13:47, Hartmut Knaack wrote: >> Daniel Baluta schrieb am 23.12.2014 um 14:22: >>> This fixes parts of kmx61 error handling to make code easier to read and to be >>> more consistent with IIO coding conventions: >>> * prefer as single point for error handling instead of duplicating code >>> for each function >>> * directly return a value from a case branch instead of breaking >>> * fix error message for writing REG_CTRL1 >>> >>> Also, add separate error paths for kmx61_trigger_setup/iio_triggered_buffer_setup >>> calls. >> Some issues remain in this one, please see inline. Otherwise looking good. >> > Fixed up and applied. Thanks for doing this Jonathan. Daniel.