From: Lars-Peter Clausen <lars@metafoo.de>
To: Karol Wrona <k.wrona@samsung.com>,
Jonathan Cameron <jic23@kernel.org>,
linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
linux-kernel@vger.kernel.org
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Karol Wrona <wrona.vy@gmail.com>
Subject: Re: [PATCH 2/2] iio: Deselect IIO_TRIGGER for IIO_KFIFO_BUF
Date: Sat, 10 Jan 2015 12:11:54 +0100 [thread overview]
Message-ID: <54B108FA.6010704@metafoo.de> (raw)
In-Reply-To: <1420735227-21091-3-git-send-email-k.wrona@samsung.com>
On 01/08/2015 05:40 PM, Karol Wrona wrote:
> iio kfifo can be used without trigger support so there is no need to build it.
>
> Signed-off-by: Karol Wrona <k.wrona@samsung.com>
Looks good, not sure why this was ever selected it in the first place.
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
> drivers/iio/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/Kconfig b/drivers/iio/Kconfig
> index 50f6599..dfda2c3 100644
> --- a/drivers/iio/Kconfig
> +++ b/drivers/iio/Kconfig
> @@ -27,7 +27,6 @@ boolean "IIO callback buffer used for push in-kernel interfaces"
> usage. That is, those where the data is pushed to the consumer.
>
> config IIO_KFIFO_BUF
> - select IIO_TRIGGER
> tristate "Industrial I/O buffering based on kfifo"
> help
> A simple fifo based on kfifo. Note that this currently provides
>
next prev parent reply other threads:[~2015-01-10 11:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 16:40 [PATCH 0/2] iio: Add no-triggered buffer helper functions Karol Wrona
2015-01-08 16:40 ` [PATCH 1/2] " Karol Wrona
2015-01-10 11:10 ` Lars-Peter Clausen
2015-01-10 18:22 ` Jonathan Cameron
2015-01-12 9:31 ` Karol Wrona
2015-01-08 16:40 ` [PATCH 2/2] iio: Deselect IIO_TRIGGER for IIO_KFIFO_BUF Karol Wrona
2015-01-10 11:11 ` Lars-Peter Clausen [this message]
2015-01-10 18:19 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B108FA.6010704@metafoo.de \
--to=lars@metafoo.de \
--cc=b.zolnierkie@samsung.com \
--cc=jic23@kernel.org \
--cc=k.wrona@samsung.com \
--cc=knaack.h@gmx.de \
--cc=kyungmin.park@samsung.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=wrona.vy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).