From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:58766 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753012AbbAJSTS (ORCPT ); Sat, 10 Jan 2015 13:19:18 -0500 Message-ID: <54B16D24.8090704@kernel.org> Date: Sat, 10 Jan 2015 18:19:16 +0000 From: Jonathan Cameron MIME-Version: 1.0 To: Lars-Peter Clausen , Karol Wrona , linux-iio@vger.kernel.org, Hartmut Knaack , Peter Meerwald , linux-kernel@vger.kernel.org CC: Bartlomiej Zolnierkiewicz , Kyungmin Park , Karol Wrona Subject: Re: [PATCH 2/2] iio: Deselect IIO_TRIGGER for IIO_KFIFO_BUF References: <1420735227-21091-1-git-send-email-k.wrona@samsung.com> <1420735227-21091-3-git-send-email-k.wrona@samsung.com> <54B108FA.6010704@metafoo.de> In-Reply-To: <54B108FA.6010704@metafoo.de> Content-Type: text/plain; charset=windows-1252 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 10/01/15 11:11, Lars-Peter Clausen wrote: > On 01/08/2015 05:40 PM, Karol Wrona wrote: >> iio kfifo can be used without trigger support so there is no need to build it. >> >> Signed-off-by: Karol Wrona > > Looks good, not sure why this was ever selected it in the first place. > > Reviewed-by: Lars-Peter Clausen Applied to the togreg branch of iio.git initially pushed out as testing. That's certainly been there a while. I got bored looking for the source when we hit the move out of staging :) oops for a long time ago - though prior to there being any examples where a kfifo didn't meant there was a trigger as well. J > >> --- >> drivers/iio/Kconfig | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/iio/Kconfig b/drivers/iio/Kconfig >> index 50f6599..dfda2c3 100644 >> --- a/drivers/iio/Kconfig >> +++ b/drivers/iio/Kconfig >> @@ -27,7 +27,6 @@ boolean "IIO callback buffer used for push in-kernel interfaces" >> usage. That is, those where the data is pushed to the consumer. >> >> config IIO_KFIFO_BUF >> - select IIO_TRIGGER >> tristate "Industrial I/O buffering based on kfifo" >> help >> A simple fifo based on kfifo. Note that this currently provides >> >