From: Jonathan Cameron <jic23@kernel.org>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: linux-iio@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>,
Jean Delvare <khali@linux-fr.org>
Subject: Re: [PATCH] iio: magnetometer: ak8975: Add AK8963
Date: Sat, 10 Jan 2015 18:33:14 +0000 [thread overview]
Message-ID: <54B1706A.3080809@kernel.org> (raw)
In-Reply-To: <1420846238-31802-1-git-send-email-srinivas.pandruvada@linux.intel.com>
On 09/01/15 23:30, Srinivas Pandruvada wrote:
> Added AK8963 in the id table. Unfortunately some commercial devices
> using caps version ak8963.
>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Hmm. I'm not sure what the general opinion on supporting this sort of
mess up is.
Are we talking naming provided from a device tree or via old fashioned board
files? If the board files I'd be inclined to say they are running a custom
kernel anyway so can patch this driver themselves. If device tree I guess
we probably do need to support it - perhaps as a deprecated binding?
Wolfram / Jean - you guys must have seen this before. Did you let
the capital form in alongside the lower case one? I guessing no ;)
I did a quick grep of hwmon and couldn't find any instances of this...
Jonathan
> ---
> drivers/iio/magnetometer/ak8975.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c
> index 0d10a4b..b13936d 100644
> --- a/drivers/iio/magnetometer/ak8975.c
> +++ b/drivers/iio/magnetometer/ak8975.c
> @@ -813,6 +813,7 @@ static int ak8975_probe(struct i2c_client *client,
> static const struct i2c_device_id ak8975_id[] = {
> {"ak8975", AK8975},
> {"ak8963", AK8963},
> + {"AK8963", AK8963},
> {"ak09911", AK09911},
> {"ak09912", AK09912},
> {}
>
next prev parent reply other threads:[~2015-01-10 18:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 23:30 [PATCH] iio: magnetometer: ak8975: Add AK8963 Srinivas Pandruvada
2015-01-10 18:33 ` Jonathan Cameron [this message]
2015-01-11 23:04 ` Srinivas Pandruvada
2015-01-12 21:25 ` Jonathan Cameron
2015-01-26 22:07 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B1706A.3080809@kernel.org \
--to=jic23@kernel.org \
--cc=khali@linux-fr.org \
--cc=linux-iio@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).