linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Jonathan Cameron <jic23@kernel.org>,
	jkosina@suse.cz, a.zummo@towertech.it
Cc: linux-iio@vger.kernel.org, linux-input@vger.kernel.org,
	holler@ahsoftware.de, rtc-linux@googlegroups.com
Subject: Re: [PATCH 2/9] iio: hid-sensor-accel-3d: Adjust parameter for attribute read
Date: Sun, 11 Jan 2015 15:08:54 -0800	[thread overview]
Message-ID: <54B30286.7090106@linux.intel.com> (raw)
In-Reply-To: <54B1AAD6.6070303@kernel.org>


On 01/10/2015 02:42 PM, Jonathan Cameron wrote:
> On 07/01/15 18:47, Srinivas Pandruvada wrote:
>> The new API added a flag for sync/async mode. Added sync mode flag.
>>
>> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Again, please don't break the build between patches like this.
As we did in the past, the hid sensor hub patches involving hid sensor 
and IIO part goes through one tree, either via IIO or HID.
So once acked this needs to go through a single tree, as done in the past.
So the patches submitted in a series to avoid breaking build.

Thanks,
Srinivas
>
> If you want to do things in steps, you'll have to carry to versions of
> the function during the conversion and drop the unwanted one at the end.
>
>> ---
>>   drivers/iio/accel/hid-sensor-accel-3d.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/accel/hid-sensor-accel-3d.c b/drivers/iio/accel/hid-sensor-accel-3d.c
>> index d5d9531..0085c2f 100644
>> --- a/drivers/iio/accel/hid-sensor-accel-3d.c
>> +++ b/drivers/iio/accel/hid-sensor-accel-3d.c
>> @@ -130,7 +130,8 @@ static int accel_3d_read_raw(struct iio_dev *indio_dev,
>>   			*val = sensor_hub_input_attr_get_raw_value(
>>   					accel_state->common_attributes.hsdev,
>>   					HID_USAGE_SENSOR_ACCEL_3D, address,
>> -					report_id);
>> +					report_id,
>> +					SENSOR_HUB_SYNC);
>>   		else {
>>   			*val = 0;
>>   			hid_sensor_power_state(&accel_state->common_attributes,
>>
>

  reply	other threads:[~2015-01-11 23:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-07 18:47 [PATCH 0/9] Asynchronous attribute reads Srinivas Pandruvada
2015-01-07 18:47 ` [PATCH 1/9] HID: hid-sensor-hub: Extend API for async reads Srinivas Pandruvada
2015-01-10 22:43   ` Jonathan Cameron
2015-01-07 18:47 ` [PATCH 2/9] iio: hid-sensor-accel-3d: Adjust parameter for attribute read Srinivas Pandruvada
2015-01-10 22:42   ` Jonathan Cameron
2015-01-11 23:08     ` Srinivas Pandruvada [this message]
2015-01-11 23:24       ` Srinivas Pandruvada
2015-01-12 21:24         ` Jonathan Cameron
2015-01-12 21:33           ` Srinivas Pandruvada
2015-01-07 18:47 ` [PATCH 3/9] iio: hid-sensor-gyro-3d: " Srinivas Pandruvada
2015-01-07 18:47 ` [PATCH 4/9] iio: hid-sensor-als: " Srinivas Pandruvada
2015-01-07 18:47 ` [PATCH 5/9] iio: hid-sensor-prox: " Srinivas Pandruvada
2015-01-07 18:48 ` [PATCH 6/9] iio: hid-sensor-magn-3d: " Srinivas Pandruvada
2015-01-07 18:48 ` [PATCH 7/9] iio: hid-sensor-incl-3d: " Srinivas Pandruvada
2015-01-07 18:48 ` [PATCH 8/9] iio: hid-sensor-press: " Srinivas Pandruvada
2015-01-07 18:48 ` [PATCH 9/9] drivers/rtc/rtc-hid-sensor-time.c: " Srinivas Pandruvada
  -- strict thread matches above, loose matches on Subject: below --
2015-01-07  0:58 [PATCH] HID: hid-sensor-hub: Correct documentation Srinivas Pandruvada
2015-01-07  0:58 ` [PATCH 2/9] iio: hid-sensor-accel-3d: Adjust parameter for attribute read Srinivas Pandruvada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B30286.7090106@linux.intel.com \
    --to=srinivas.pandruvada@linux.intel.com \
    --cc=a.zummo@towertech.it \
    --cc=holler@ahsoftware.de \
    --cc=jic23@kernel.org \
    --cc=jkosina@suse.cz \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).