Re: [PATCH 2/4] iio: mxs-lradc: make ADC reads not disable touchscreen interrupts

["Kristina Martšenko" <kristina.martsenko@gmail.com>]

On 18/01/15 02:21, Marek Vasut wrote:
> On Saturday, January 17, 2015 at 01:22:09 AM, Kristina Martšenko wrote:
>> Reading a channel through sysfs, or starting a buffered capture, will
>> currently turn off the touchscreen. This is because the read_raw() and
>> buffer preenable()/postdisable() callbacks disable interrupts for all
>> LRADC channels, including those the touchscreen uses.
>>
>> So make the callbacks only disable interrupts for the channels they use.
>> This means channel 0 for read_raw() and channels 0-5 for the buffer (if
>> the touchscreen is enabled). Since the touchscreen uses different
>> channels (6 and 7), it no longer gets turned off.
>>
>> Note that only i.MX28 is affected by this issue, i.MX23 should be fine.
>>
>> Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com>
>> ---
>>  drivers/staging/iio/adc/mxs-lradc.c | 24 +++++++++++++++++-------
>>  1 file changed, 17 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/staging/iio/adc/mxs-lradc.c
>> b/drivers/staging/iio/adc/mxs-lradc.c index fc65cd311be9..0cf276ff0dc5
>> 100644
>> --- a/drivers/staging/iio/adc/mxs-lradc.c
>> +++ b/drivers/staging/iio/adc/mxs-lradc.c
>> @@ -218,8 +218,11 @@ struct mxs_lradc {
>>  	 * channels: #6 and #7. This means that only 6 virtual channels (instead
>>  	 * of 8) will be available for buffered capture.
>>  	 */
>> -#define TS_VCH1		7
>> -#define TS_VCH2		6
>> +#define TS_VCH1				7
>> +#define TS_VCH2				6
> 
> Please fix the indent in 1/4 , so you don't have to change it again this patch.

Right, of course, I'll do that in v2.

> Reviewed-by: Marek Vasut <marex@denx.de>

Thanks for taking time to review all the patches!

Kristina