* [PATCH] staging: iio: ad5933: fix format string warnings
@ 2015-01-20 7:25 Asaf Vertz
2015-01-20 8:52 ` Lars-Peter Clausen
0 siblings, 1 reply; 3+ messages in thread
From: Asaf Vertz @ 2015-01-20 7:25 UTC (permalink / raw)
To: gregkh
Cc: lars, Michael.Hennerich, jic23, knaack.h, pmeerw, linux-iio,
devel, linux-kernel
Fixed the following warnings (reported by cppcheck):
[drivers/staging/iio/impedance-analyzer/ad5933.c:363]: (warning) %d in format string (no. 1)
requires 'int' but the argument type is 'unsigned int'.
[drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 1)
requires 'int' but the argument type is 'unsigned int'.
[drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 2)
requires 'int' but the argument type is 'unsigned int'.
[drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 3)
requires 'int' but the argument type is 'unsigned int'.
[drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 4)
requires 'int' but the argument type is 'unsigned int'.
Signed-off-by: Asaf Vertz <asaf.vertz@tandemg.com>
---
drivers/staging/iio/impedance-analyzer/ad5933.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c
index b6bd609..4230a43 100644
--- a/drivers/staging/iio/impedance-analyzer/ad5933.c
+++ b/drivers/staging/iio/impedance-analyzer/ad5933.c
@@ -360,11 +360,11 @@ static ssize_t ad5933_show(struct device *dev,
mutex_lock(&indio_dev->mlock);
switch ((u32) this_attr->address) {
case AD5933_OUT_RANGE:
- len = sprintf(buf, "%d\n",
+ len = sprintf(buf, "%u\n",
st->range_avail[(st->ctrl_hb >> 1) & 0x3]);
break;
case AD5933_OUT_RANGE_AVAIL:
- len = sprintf(buf, "%d %d %d %d\n", st->range_avail[0],
+ len = sprintf(buf, "%u %u %u %u\n", st->range_avail[0],
st->range_avail[3], st->range_avail[2],
st->range_avail[1]);
break;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: iio: ad5933: fix format string warnings
2015-01-20 7:25 [PATCH] staging: iio: ad5933: fix format string warnings Asaf Vertz
@ 2015-01-20 8:52 ` Lars-Peter Clausen
2015-01-20 20:45 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Lars-Peter Clausen @ 2015-01-20 8:52 UTC (permalink / raw)
To: Asaf Vertz, gregkh
Cc: Michael.Hennerich, jic23, knaack.h, pmeerw, linux-iio, devel,
linux-kernel
On 01/20/2015 08:25 AM, Asaf Vertz wrote:
> Fixed the following warnings (reported by cppcheck):
> [drivers/staging/iio/impedance-analyzer/ad5933.c:363]: (warning) %d in format string (no. 1)
> requires 'int' but the argument type is 'unsigned int'.
> [drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 1)
> requires 'int' but the argument type is 'unsigned int'.
> [drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 2)
> requires 'int' but the argument type is 'unsigned int'.
> [drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 3)
> requires 'int' but the argument type is 'unsigned int'.
> [drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 4)
> requires 'int' but the argument type is 'unsigned int'.
>
> Signed-off-by: Asaf Vertz <asaf.vertz@tandemg.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks.
> ---
> drivers/staging/iio/impedance-analyzer/ad5933.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c
> index b6bd609..4230a43 100644
> --- a/drivers/staging/iio/impedance-analyzer/ad5933.c
> +++ b/drivers/staging/iio/impedance-analyzer/ad5933.c
> @@ -360,11 +360,11 @@ static ssize_t ad5933_show(struct device *dev,
> mutex_lock(&indio_dev->mlock);
> switch ((u32) this_attr->address) {
> case AD5933_OUT_RANGE:
> - len = sprintf(buf, "%d\n",
> + len = sprintf(buf, "%u\n",
> st->range_avail[(st->ctrl_hb >> 1) & 0x3]);
> break;
> case AD5933_OUT_RANGE_AVAIL:
> - len = sprintf(buf, "%d %d %d %d\n", st->range_avail[0],
> + len = sprintf(buf, "%u %u %u %u\n", st->range_avail[0],
> st->range_avail[3], st->range_avail[2],
> st->range_avail[1]);
> break;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: iio: ad5933: fix format string warnings
2015-01-20 8:52 ` Lars-Peter Clausen
@ 2015-01-20 20:45 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2015-01-20 20:45 UTC (permalink / raw)
To: Lars-Peter Clausen, Asaf Vertz, gregkh
Cc: Michael.Hennerich, knaack.h, pmeerw, linux-iio, devel,
linux-kernel
On 20/01/15 08:52, Lars-Peter Clausen wrote:
> On 01/20/2015 08:25 AM, Asaf Vertz wrote:
>> Fixed the following warnings (reported by cppcheck):
>> [drivers/staging/iio/impedance-analyzer/ad5933.c:363]: (warning) %d in format string (no. 1)
>> requires 'int' but the argument type is 'unsigned int'.
>> [drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 1)
>> requires 'int' but the argument type is 'unsigned int'.
>> [drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 2)
>> requires 'int' but the argument type is 'unsigned int'.
>> [drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 3)
>> requires 'int' but the argument type is 'unsigned int'.
>> [drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 4)
>> requires 'int' but the argument type is 'unsigned int'.
>>
>> Signed-off-by: Asaf Vertz <asaf.vertz@tandemg.com>
>
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Applied to the togreg branch of iio.git. Initially pushed out
as testing. Thanks,
Jonathan
>
> Thanks.
>
>> ---
>> drivers/staging/iio/impedance-analyzer/ad5933.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c
>> index b6bd609..4230a43 100644
>> --- a/drivers/staging/iio/impedance-analyzer/ad5933.c
>> +++ b/drivers/staging/iio/impedance-analyzer/ad5933.c
>> @@ -360,11 +360,11 @@ static ssize_t ad5933_show(struct device *dev,
>> mutex_lock(&indio_dev->mlock);
>> switch ((u32) this_attr->address) {
>> case AD5933_OUT_RANGE:
>> - len = sprintf(buf, "%d\n",
>> + len = sprintf(buf, "%u\n",
>> st->range_avail[(st->ctrl_hb >> 1) & 0x3]);
>> break;
>> case AD5933_OUT_RANGE_AVAIL:
>> - len = sprintf(buf, "%d %d %d %d\n", st->range_avail[0],
>> + len = sprintf(buf, "%u %u %u %u\n", st->range_avail[0],
>> st->range_avail[3], st->range_avail[2],
>> st->range_avail[1]);
>> break;
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-20 20:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-20 7:25 [PATCH] staging: iio: ad5933: fix format string warnings Asaf Vertz
2015-01-20 8:52 ` Lars-Peter Clausen
2015-01-20 20:45 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).