From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>,
Asaf Vertz <asaf.vertz@tandemg.com>,
gregkh@linuxfoundation.org
Cc: Michael.Hennerich@analog.com, knaack.h@gmx.de, pmeerw@pmeerw.net,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: iio: ad5933: fix format string warnings
Date: Tue, 20 Jan 2015 20:45:38 +0000 [thread overview]
Message-ID: <54BEBE72.5020106@kernel.org> (raw)
In-Reply-To: <54BE175D.3070504@metafoo.de>
On 20/01/15 08:52, Lars-Peter Clausen wrote:
> On 01/20/2015 08:25 AM, Asaf Vertz wrote:
>> Fixed the following warnings (reported by cppcheck):
>> [drivers/staging/iio/impedance-analyzer/ad5933.c:363]: (warning) %d in format string (no. 1)
>> requires 'int' but the argument type is 'unsigned int'.
>> [drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 1)
>> requires 'int' but the argument type is 'unsigned int'.
>> [drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 2)
>> requires 'int' but the argument type is 'unsigned int'.
>> [drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 3)
>> requires 'int' but the argument type is 'unsigned int'.
>> [drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 4)
>> requires 'int' but the argument type is 'unsigned int'.
>>
>> Signed-off-by: Asaf Vertz <asaf.vertz@tandemg.com>
>
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Applied to the togreg branch of iio.git. Initially pushed out
as testing. Thanks,
Jonathan
>
> Thanks.
>
>> ---
>> drivers/staging/iio/impedance-analyzer/ad5933.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c
>> index b6bd609..4230a43 100644
>> --- a/drivers/staging/iio/impedance-analyzer/ad5933.c
>> +++ b/drivers/staging/iio/impedance-analyzer/ad5933.c
>> @@ -360,11 +360,11 @@ static ssize_t ad5933_show(struct device *dev,
>> mutex_lock(&indio_dev->mlock);
>> switch ((u32) this_attr->address) {
>> case AD5933_OUT_RANGE:
>> - len = sprintf(buf, "%d\n",
>> + len = sprintf(buf, "%u\n",
>> st->range_avail[(st->ctrl_hb >> 1) & 0x3]);
>> break;
>> case AD5933_OUT_RANGE_AVAIL:
>> - len = sprintf(buf, "%d %d %d %d\n", st->range_avail[0],
>> + len = sprintf(buf, "%u %u %u %u\n", st->range_avail[0],
>> st->range_avail[3], st->range_avail[2],
>> st->range_avail[1]);
>> break;
>>
>
prev parent reply other threads:[~2015-01-20 20:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 7:25 [PATCH] staging: iio: ad5933: fix format string warnings Asaf Vertz
2015-01-20 8:52 ` Lars-Peter Clausen
2015-01-20 20:45 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BEBE72.5020106@kernel.org \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=asaf.vertz@tandemg.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).