From: Lars-Peter Clausen <lars@metafoo.de>
To: varkabhadram@gmail.com, linux-iio@vger.kernel.org
Cc: jic23@kernel.org, Varka Bhadram <varkab@cdac.in>
Subject: Re: [PATCH iio 1/3] imu: inv_mpu6050: use devm_request_irq
Date: Wed, 21 Jan 2015 11:19:16 +0100 [thread overview]
Message-ID: <54BF7D24.5090009@metafoo.de> (raw)
In-Reply-To: <1421819977-32232-1-git-send-email-varkabhadram@gmail.com>
On 01/21/2015 06:59 AM, varkabhadram@gmail.com wrote:
[...]
> void inv_mpu6050_remove_trigger(struct inv_mpu6050_state *st)
> {
> iio_trigger_unregister(st->trig);
> - free_irq(st->client->irq, st->trig);
> iio_trigger_free(st->trig);
You are changing the relative order between free_irq() and
iio_trigger_free() here and by doing so introduce a use-after-free race
condition. The IRQ handler uses the trigger, so the IRQ has to be released
before the trigger is freed.
This can be easily fixed though by changing the order of patch 1 and patch 2
in this series.
next prev parent reply other threads:[~2015-01-21 10:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 5:59 [PATCH iio 1/3] imu: inv_mpu6050: use devm_request_irq varkabhadram
2015-01-21 5:59 ` [PATCH iio 2/3] imu: inv_mpu6050: use devm_iio_trigger_alloc varkabhadram
2015-01-21 5:59 ` [PATCH iio 3/3] imu: inv_mpu6050: cleanup on error check varkabhadram
2015-01-21 10:19 ` Lars-Peter Clausen [this message]
2015-01-21 11:14 ` [PATCH iio 1/3] imu: inv_mpu6050: use devm_request_irq Varka Bhadram
2015-01-21 17:25 ` Jonathan Cameron
2015-01-22 3:09 ` Varka Bhadram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BF7D24.5090009@metafoo.de \
--to=lars@metafoo.de \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=varkab@cdac.in \
--cc=varkabhadram@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).