From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:53244 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966250AbbBCTQr (ORCPT ); Tue, 3 Feb 2015 14:16:47 -0500 Message-ID: <54D11E9C.5030701@kernel.org> Date: Tue, 03 Feb 2015 19:16:44 +0000 From: Jonathan Cameron MIME-Version: 1.0 To: Srinivas Pandruvada CC: wsa@the-dreams.de, lars@metafoo.de, linux-iio@vger.kernel.org Subject: Re: [PATCH v3] iio: imu: inv_mpu6050: client enumeration References: <1422656745-13576-1-git-send-email-srinivas.pandruvada@linux.intel.com> In-Reply-To: <1422656745-13576-1-git-send-email-srinivas.pandruvada@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 30/01/15 22:25, Srinivas Pandruvada wrote: > Last comment from Jonathan was > " > This all looks fine to me, though ideally I'd like some input from > others, more familiar with the dmi stuff etc and from Wolfram / others > wrt to the approach. > " Given timing, (just missed likely merge this cycle) we now have a reasonable amount of time. So lets leave this a little while yet... > > So anybody have a better suggestion, I am still open to take them. > Otherwise please consider as a merge candidate. > > v3 > Add CONFIG_ACPI protection to avoid compiler warning. > > v2 > Add CONFIG_ACPI to call creation of mux clients, instead of relying > on ACPI_HANDLE not present for non ACPI platforms > It is possible that there is no secondary address, this is not an error. > > v1 > This is an option if auto detect is not desired. > Here using ACPI magic, by parsing both standard and vendor ACPI > data. > > v0 > Using autodetect feature. > Using HWMON class as other places in the system for mux and > client sensor drivers. > > Srinivas Pandruvada (1): > iio: imu: inv_mpu6050: Create mux clients for ACPI > > drivers/iio/imu/inv_mpu6050/Makefile | 2 +- > drivers/iio/imu/inv_mpu6050/inv_mpu_acpi.c | 211 +++++++++++++++++++++++++++++ > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 7 + > drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h | 3 + > 4 files changed, 222 insertions(+), 1 deletion(-) > create mode 100644 drivers/iio/imu/inv_mpu6050/inv_mpu_acpi.c >