From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-iio-owner@vger.kernel.org>
Received: from mailout3.w1.samsung.com ([210.118.77.13]:28807 "EHLO
	mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750978AbbBRMlS (ORCPT
	<rfc822;linux-iio@vger.kernel.org>); Wed, 18 Feb 2015 07:41:18 -0500
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Message-id: <54E4886A.5080902@samsung.com>
Date: Wed, 18 Feb 2015 13:41:14 +0100
From: Karol Wrona <k.wrona@samsung.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
	Jonathan Cameron <jic23@kernel.org>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: common: ssp_sensors: Protect PM-only functions to
 kill warning
References: <1424259586-29334-1-git-send-email-geert@linux-m68k.org>
In-reply-to: <1424259586-29334-1-git-send-email-geert@linux-m68k.org>
Sender: linux-iio-owner@vger.kernel.org
List-Id: linux-iio@vger.kernel.org

On 02/18/2015 12:39 PM, Geert Uytterhoeven wrote:
> If CONFIG_PM_SLEEP=n:
> 
>     drivers/iio/common/ssp_sensors/ssp_dev.c:644: warning: ‘ssp_suspend’ defined but not used
>     drivers/iio/common/ssp_sensors/ssp_dev.c:669: warning: ‘ssp_resume’ defined but not used
> 
> Protect the unused functions by #ifdef CONFIG_PM_SLEEP to fix this.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> v2:
>   - Fix driver name in one-line summary
> ---
>  drivers/iio/common/ssp_sensors/ssp_dev.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/iio/common/ssp_sensors/ssp_dev.c b/drivers/iio/common/ssp_sensors/ssp_dev.c
> index 52d70435f5a11c55..55a90082a29bd484 100644
> --- a/drivers/iio/common/ssp_sensors/ssp_dev.c
> +++ b/drivers/iio/common/ssp_sensors/ssp_dev.c
> @@ -640,6 +640,7 @@ static int ssp_remove(struct spi_device *spi)
>  	return 0;
>  }
>  
> +#ifdef CONFIG_PM_SLEEP
>  static int ssp_suspend(struct device *dev)
>  {
>  	int ret;
> @@ -688,6 +689,7 @@ static int ssp_resume(struct device *dev)
>  
>  	return 0;
>  }
> +#endif /* CONFIG_PM_SLEEP */
>  
>  static const struct dev_pm_ops ssp_pm_ops = {
>  	SET_SYSTEM_SLEEP_PM_OPS(ssp_suspend, ssp_resume)
> 

Acked-by: Karol Wrona <k.wrona@samsung.com>

Thanks for doing that.
Karol