linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: "Tirdea, Irina" <irina.tirdea@intel.com>,
	Peter Meerwald <pmeerw@pmeerw.net>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Pandruvada, Srinivas" <srinivas.pandruvada@intel.com>,
	"Reus, Adriana" <adriana.reus@intel.com>
Subject: Re: [PATCH 0/2] bmc150-accel driver optimizations
Date: Sat, 21 Feb 2015 18:34:34 +0000	[thread overview]
Message-ID: <54E8CFBA.1020904@kernel.org> (raw)
In-Reply-To: <1F3AC3675D538145B1661F571FE1805F19A20DE0@irsmsx105.ger.corp.intel.com>

On 20/02/15 12:05, Tirdea, Irina wrote:
> 
> 
>> -----Original Message-----
>> From: linux-iio-owner@vger.kernel.org [mailto:linux-iio-owner@vger.kernel.org] On Behalf Of Peter Meerwald
>> Sent: 16 February, 2015 21:27
>> To: Tirdea, Irina
>> Cc: Jonathan Cameron; linux-iio@vger.kernel.org; linux-kernel@vger.kernel.org; Pandruvada, Srinivas; Reus, Adriana
>> Subject: Re: [PATCH 0/2] bmc150-accel driver optimizations
>>
>>
>>> Adds optimization of i2c transactions in trigger handler and
>>> usage of available_scan_masks for bmc150-accel.
>>
>> same comments as for kxcjk-1013, this changes the capabilities of the
>> driver
>>
> Will fix the comments for all the patchsets.
> 
> Thanks,
> Irina
Same point as you made in the other driver applies here and this is fine
as the core will deal with it.

Anyhow, I'm happy with this, except for the excellent idea of putting
the emulation code into the i2c core.  No particular rush at the moment
given where we are in the cycle so might as well wait for that to pan out.

Jonathan
> 
>>> Irina Tirdea (2):
>>>   iio: accel: bmc150: use available_scan_masks
>>>   iio: accel: bmc150: optimize i2c transfers in trigger handler
>>>
>>>  drivers/iio/accel/bmc150-accel.c | 49 +++++++++++++++++++++++++++++++---------
>>>  1 file changed, 38 insertions(+), 11 deletions(-)
>>>
>>>
>>
>> --
>>
>> Peter Meerwald
>> +43-664-2444418 (mobile)
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html


      reply	other threads:[~2015-02-21 18:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-16 18:16 [PATCH 0/2] bmc150-accel driver optimizations Irina Tirdea
2015-02-16 18:17 ` [PATCH 1/2] iio: accel: bmc150: use available_scan_masks Irina Tirdea
2015-02-16 18:17 ` [PATCH 2/2] iio: accel: bmc150: optimize i2c transfers in trigger handler Irina Tirdea
2015-02-16 19:27 ` [PATCH 0/2] bmc150-accel driver optimizations Peter Meerwald
2015-02-20 12:05   ` Tirdea, Irina
2015-02-21 18:34     ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54E8CFBA.1020904@kernel.org \
    --to=jic23@kernel.org \
    --cc=adriana.reus@intel.com \
    --cc=irina.tirdea@intel.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=srinivas.pandruvada@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).