From: Jonathan Cameron <jic23@kernel.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devel@driverdev.osuosl.org
Subject: Re: [PATCH 2/2] iio: jsa1212: Constify struct regmap_config
Date: Wed, 25 Feb 2015 11:55:26 +0000 [thread overview]
Message-ID: <54EDB82E.5050406@kernel.org> (raw)
In-Reply-To: <1424770909-7360-2-git-send-email-k.kozlowski@samsung.com>
On 24/02/15 09:41, Krzysztof Kozlowski wrote:
> The regmap_config struct may be const because it is not modified by the
> driver and regmap_init() accepts pointer to const.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Applied to the togreg branch of iio.git. I'm having another of my periodic
days in a clean room (with a very dirty laptop), so will be a day or two before
I'm back home and can push out as testing for the autobuilders to play.
On the plus side, the machine I'm working on isn't running so lots of time
for patch review...
Jonathan
> ---
> drivers/iio/light/jsa1212.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/light/jsa1212.c b/drivers/iio/light/jsa1212.c
> index 29de7e7d9562..3a3af89beaf9 100644
> --- a/drivers/iio/light/jsa1212.c
> +++ b/drivers/iio/light/jsa1212.c
> @@ -308,7 +308,7 @@ static bool jsa1212_is_volatile_reg(struct device *dev, unsigned int reg)
> }
> }
>
> -static struct regmap_config jsa1212_regmap_config = {
> +static const struct regmap_config jsa1212_regmap_config = {
> .name = JSA1212_REGMAP_NAME,
> .reg_bits = 8,
> .val_bits = 8,
>
next prev parent reply other threads:[~2015-02-25 20:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 9:41 [PATCH 1/2] staging:iio:hmc5843: Constify register tables and struct regmap_config Krzysztof Kozlowski
2015-02-24 9:41 ` [PATCH 2/2] iio: jsa1212: Constify " Krzysztof Kozlowski
2015-02-25 11:55 ` Jonathan Cameron [this message]
2015-02-25 11:54 ` [PATCH 1/2] staging:iio:hmc5843: Constify register tables and " Jonathan Cameron
2015-02-26 9:11 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EDB82E.5050406@kernel.org \
--to=jic23@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=k.kozlowski@samsung.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).