* [PATCH 1/3] Staging: iio: meter: ade7854-i2c: code style improvements
@ 2015-02-15 4:32 Tolga Ceylan
2015-02-15 4:32 ` [PATCH 2/3] " Tolga Ceylan
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Tolga Ceylan @ 2015-02-15 4:32 UTC (permalink / raw)
To: Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron,
Hartmut Knaack, Peter Meerwald, Greg Kroah-Hartman, linux-iio,
devel, linux-kernel, tolga.ceylan
Code reformatting based on checkpatch.pl with --strict:
Alignment should match open paranthesis cases corrected
Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
---
drivers/staging/iio/meter/ade7854-i2c.c | 34 ++++++++++++++++-----------------
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/iio/meter/ade7854-i2c.c b/drivers/staging/iio/meter/ade7854-i2c.c
index 5b33c7f..85a7e84 100644
--- a/drivers/staging/iio/meter/ade7854-i2c.c
+++ b/drivers/staging/iio/meter/ade7854-i2c.c
@@ -16,8 +16,8 @@
#include "ade7854.h"
static int ade7854_i2c_write_reg_8(struct device *dev,
- u16 reg_address,
- u8 value)
+ u16 reg_address,
+ u8 value)
{
int ret;
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
@@ -35,8 +35,8 @@ static int ade7854_i2c_write_reg_8(struct device *dev,
}
static int ade7854_i2c_write_reg_16(struct device *dev,
- u16 reg_address,
- u16 value)
+ u16 reg_address,
+ u16 value)
{
int ret;
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
@@ -55,8 +55,8 @@ static int ade7854_i2c_write_reg_16(struct device *dev,
}
static int ade7854_i2c_write_reg_24(struct device *dev,
- u16 reg_address,
- u32 value)
+ u16 reg_address,
+ u32 value)
{
int ret;
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
@@ -76,8 +76,8 @@ static int ade7854_i2c_write_reg_24(struct device *dev,
}
static int ade7854_i2c_write_reg_32(struct device *dev,
- u16 reg_address,
- u32 value)
+ u16 reg_address,
+ u32 value)
{
int ret;
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
@@ -98,8 +98,8 @@ static int ade7854_i2c_write_reg_32(struct device *dev,
}
static int ade7854_i2c_read_reg_8(struct device *dev,
- u16 reg_address,
- u8 *val)
+ u16 reg_address,
+ u8 *val)
{
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
struct ade7854_state *st = iio_priv(indio_dev);
@@ -124,8 +124,8 @@ out:
}
static int ade7854_i2c_read_reg_16(struct device *dev,
- u16 reg_address,
- u16 *val)
+ u16 reg_address,
+ u16 *val)
{
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
struct ade7854_state *st = iio_priv(indio_dev);
@@ -150,8 +150,8 @@ out:
}
static int ade7854_i2c_read_reg_24(struct device *dev,
- u16 reg_address,
- u32 *val)
+ u16 reg_address,
+ u32 *val)
{
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
struct ade7854_state *st = iio_priv(indio_dev);
@@ -176,8 +176,8 @@ out:
}
static int ade7854_i2c_read_reg_32(struct device *dev,
- u16 reg_address,
- u32 *val)
+ u16 reg_address,
+ u32 *val)
{
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
struct ade7854_state *st = iio_priv(indio_dev);
@@ -202,7 +202,7 @@ out:
}
static int ade7854_i2c_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+ const struct i2c_device_id *id)
{
int ret;
struct ade7854_state *st;
--
2.3.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/3] Staging: iio: meter: ade7854-i2c: code style improvements
2015-02-15 4:32 [PATCH 1/3] Staging: iio: meter: ade7854-i2c: code style improvements Tolga Ceylan
@ 2015-02-15 4:32 ` Tolga Ceylan
2015-03-08 12:01 ` Jonathan Cameron
2015-02-15 4:32 ` [PATCH 3/3] " Tolga Ceylan
2015-03-08 11:59 ` [PATCH 1/3] " Jonathan Cameron
2 siblings, 1 reply; 6+ messages in thread
From: Tolga Ceylan @ 2015-02-15 4:32 UTC (permalink / raw)
To: Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron,
Hartmut Knaack, Peter Meerwald, Greg Kroah-Hartman, linux-iio,
devel, linux-kernel, tolga.ceylan
Code reformatting based on checkpatch.pl with --strict:
Lines over 80 characters were fixed
Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
---
drivers/staging/iio/meter/ade7854-i2c.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/iio/meter/ade7854-i2c.c b/drivers/staging/iio/meter/ade7854-i2c.c
index 85a7e84..5e6fbe4 100644
--- a/drivers/staging/iio/meter/ade7854-i2c.c
+++ b/drivers/staging/iio/meter/ade7854-i2c.c
@@ -195,7 +195,8 @@ static int ade7854_i2c_read_reg_32(struct device *dev,
if (ret)
goto out;
- *val = (st->rx[0] << 24) | (st->rx[1] << 16) | (st->rx[2] << 8) | st->rx[3];
+ *val = (st->rx[0] << 24) | (st->rx[1] << 16) |
+ (st->rx[2] << 8) | st->rx[3];
out:
mutex_unlock(&st->buf_lock);
return ret;
--
2.3.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] Staging: iio: meter: ade7854-i2c: code style improvements
2015-02-15 4:32 ` [PATCH 2/3] " Tolga Ceylan
@ 2015-03-08 12:01 ` Jonathan Cameron
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2015-03-08 12:01 UTC (permalink / raw)
To: Tolga Ceylan, Lars-Peter Clausen, Michael Hennerich,
Hartmut Knaack, Peter Meerwald, Greg Kroah-Hartman, linux-iio,
devel, linux-kernel
On 15/02/15 04:32, Tolga Ceylan wrote:
> Code reformatting based on checkpatch.pl with --strict:
> Lines over 80 characters were fixed
>
> Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
You sent me a patch for this a week before this one which was applied.
So already done :)
> ---
> drivers/staging/iio/meter/ade7854-i2c.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/meter/ade7854-i2c.c b/drivers/staging/iio/meter/ade7854-i2c.c
> index 85a7e84..5e6fbe4 100644
> --- a/drivers/staging/iio/meter/ade7854-i2c.c
> +++ b/drivers/staging/iio/meter/ade7854-i2c.c
> @@ -195,7 +195,8 @@ static int ade7854_i2c_read_reg_32(struct device *dev,
> if (ret)
> goto out;
>
> - *val = (st->rx[0] << 24) | (st->rx[1] << 16) | (st->rx[2] << 8) | st->rx[3];
> + *val = (st->rx[0] << 24) | (st->rx[1] << 16) |
> + (st->rx[2] << 8) | st->rx[3];
> out:
> mutex_unlock(&st->buf_lock);
> return ret;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3/3] Staging: iio: meter: ade7854-i2c: code style improvements
2015-02-15 4:32 [PATCH 1/3] Staging: iio: meter: ade7854-i2c: code style improvements Tolga Ceylan
2015-02-15 4:32 ` [PATCH 2/3] " Tolga Ceylan
@ 2015-02-15 4:32 ` Tolga Ceylan
2015-03-08 12:02 ` Jonathan Cameron
2015-03-08 11:59 ` [PATCH 1/3] " Jonathan Cameron
2 siblings, 1 reply; 6+ messages in thread
From: Tolga Ceylan @ 2015-02-15 4:32 UTC (permalink / raw)
To: Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron,
Hartmut Knaack, Peter Meerwald, Greg Kroah-Hartman, linux-iio,
devel, linux-kernel, tolga.ceylan
Code reformatting based on checkpatch.pl with --strict:
Comparison to NULL rewritten as !indio_dev
Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
---
drivers/staging/iio/meter/ade7854-i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/meter/ade7854-i2c.c b/drivers/staging/iio/meter/ade7854-i2c.c
index 5e6fbe4..4e7a382 100644
--- a/drivers/staging/iio/meter/ade7854-i2c.c
+++ b/drivers/staging/iio/meter/ade7854-i2c.c
@@ -210,7 +210,7 @@ static int ade7854_i2c_probe(struct i2c_client *client,
struct iio_dev *indio_dev;
indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*st));
- if (indio_dev == NULL)
+ if (!indio_dev)
return -ENOMEM;
st = iio_priv(indio_dev);
i2c_set_clientdata(client, indio_dev);
--
2.3.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] Staging: iio: meter: ade7854-i2c: code style improvements
2015-02-15 4:32 ` [PATCH 3/3] " Tolga Ceylan
@ 2015-03-08 12:02 ` Jonathan Cameron
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2015-03-08 12:02 UTC (permalink / raw)
To: Tolga Ceylan, Lars-Peter Clausen, Michael Hennerich,
Hartmut Knaack, Peter Meerwald, Greg Kroah-Hartman, linux-iio,
devel, linux-kernel
On 15/02/15 04:32, Tolga Ceylan wrote:
> Code reformatting based on checkpatch.pl with --strict:
> Comparison to NULL rewritten as !indio_dev
>
> Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
Whilst I find it hard to care on this particular fix.. what the heck.
Applied to the togreg branch of iio.git.
Thanks,
Jonathan
> ---
> drivers/staging/iio/meter/ade7854-i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/meter/ade7854-i2c.c b/drivers/staging/iio/meter/ade7854-i2c.c
> index 5e6fbe4..4e7a382 100644
> --- a/drivers/staging/iio/meter/ade7854-i2c.c
> +++ b/drivers/staging/iio/meter/ade7854-i2c.c
> @@ -210,7 +210,7 @@ static int ade7854_i2c_probe(struct i2c_client *client,
> struct iio_dev *indio_dev;
>
> indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*st));
> - if (indio_dev == NULL)
> + if (!indio_dev)
> return -ENOMEM;
> st = iio_priv(indio_dev);
> i2c_set_clientdata(client, indio_dev);
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] Staging: iio: meter: ade7854-i2c: code style improvements
2015-02-15 4:32 [PATCH 1/3] Staging: iio: meter: ade7854-i2c: code style improvements Tolga Ceylan
2015-02-15 4:32 ` [PATCH 2/3] " Tolga Ceylan
2015-02-15 4:32 ` [PATCH 3/3] " Tolga Ceylan
@ 2015-03-08 11:59 ` Jonathan Cameron
2 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2015-03-08 11:59 UTC (permalink / raw)
To: Tolga Ceylan, Lars-Peter Clausen, Michael Hennerich,
Hartmut Knaack, Peter Meerwald, Greg Kroah-Hartman, linux-iio,
devel, linux-kernel
On 15/02/15 04:32, Tolga Ceylan wrote:
> Code reformatting based on checkpatch.pl with --strict:
> Alignment should match open paranthesis cases corrected
>
> Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
Applied to the togreg branch of iio.git - will initially be pushed
out as testing for the autobuilders to play.
Thanks
Jonathan
> ---
> drivers/staging/iio/meter/ade7854-i2c.c | 34 ++++++++++++++++-----------------
> 1 file changed, 17 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/staging/iio/meter/ade7854-i2c.c b/drivers/staging/iio/meter/ade7854-i2c.c
> index 5b33c7f..85a7e84 100644
> --- a/drivers/staging/iio/meter/ade7854-i2c.c
> +++ b/drivers/staging/iio/meter/ade7854-i2c.c
> @@ -16,8 +16,8 @@
> #include "ade7854.h"
>
> static int ade7854_i2c_write_reg_8(struct device *dev,
> - u16 reg_address,
> - u8 value)
> + u16 reg_address,
> + u8 value)
> {
> int ret;
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> @@ -35,8 +35,8 @@ static int ade7854_i2c_write_reg_8(struct device *dev,
> }
>
> static int ade7854_i2c_write_reg_16(struct device *dev,
> - u16 reg_address,
> - u16 value)
> + u16 reg_address,
> + u16 value)
> {
> int ret;
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> @@ -55,8 +55,8 @@ static int ade7854_i2c_write_reg_16(struct device *dev,
> }
>
> static int ade7854_i2c_write_reg_24(struct device *dev,
> - u16 reg_address,
> - u32 value)
> + u16 reg_address,
> + u32 value)
> {
> int ret;
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> @@ -76,8 +76,8 @@ static int ade7854_i2c_write_reg_24(struct device *dev,
> }
>
> static int ade7854_i2c_write_reg_32(struct device *dev,
> - u16 reg_address,
> - u32 value)
> + u16 reg_address,
> + u32 value)
> {
> int ret;
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> @@ -98,8 +98,8 @@ static int ade7854_i2c_write_reg_32(struct device *dev,
> }
>
> static int ade7854_i2c_read_reg_8(struct device *dev,
> - u16 reg_address,
> - u8 *val)
> + u16 reg_address,
> + u8 *val)
> {
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> struct ade7854_state *st = iio_priv(indio_dev);
> @@ -124,8 +124,8 @@ out:
> }
>
> static int ade7854_i2c_read_reg_16(struct device *dev,
> - u16 reg_address,
> - u16 *val)
> + u16 reg_address,
> + u16 *val)
> {
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> struct ade7854_state *st = iio_priv(indio_dev);
> @@ -150,8 +150,8 @@ out:
> }
>
> static int ade7854_i2c_read_reg_24(struct device *dev,
> - u16 reg_address,
> - u32 *val)
> + u16 reg_address,
> + u32 *val)
> {
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> struct ade7854_state *st = iio_priv(indio_dev);
> @@ -176,8 +176,8 @@ out:
> }
>
> static int ade7854_i2c_read_reg_32(struct device *dev,
> - u16 reg_address,
> - u32 *val)
> + u16 reg_address,
> + u32 *val)
> {
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> struct ade7854_state *st = iio_priv(indio_dev);
> @@ -202,7 +202,7 @@ out:
> }
>
> static int ade7854_i2c_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> + const struct i2c_device_id *id)
> {
> int ret;
> struct ade7854_state *st;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-03-08 12:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-15 4:32 [PATCH 1/3] Staging: iio: meter: ade7854-i2c: code style improvements Tolga Ceylan
2015-02-15 4:32 ` [PATCH 2/3] " Tolga Ceylan
2015-03-08 12:01 ` Jonathan Cameron
2015-02-15 4:32 ` [PATCH 3/3] " Tolga Ceylan
2015-03-08 12:02 ` Jonathan Cameron
2015-03-08 11:59 ` [PATCH 1/3] " Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).