* [PATCH] staging: iio: dummy: Fix undefined symbol build error
@ 2015-03-09 10:15 Daniel Baluta
2015-03-09 10:56 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Baluta @ 2015-03-09 10:15 UTC (permalink / raw)
To: jic23; +Cc: linux-iio, pmeerw, lars, knaack.h, arnd, fengguang.wu
CONFIG_SIMPLE_DUMMY_BUFFER compiles in iio_simple_dummy_buffer.c file
which uses functions from industrialio-trigger.c.
So, CONFIG_SIMPLE_DUMMY_BUFFER needs to select IIO_TRIGGER in order to
avoid build error like this:
> ERROR: "iio_trigger_notify_done" [drivers/staging/iio/iio_dummy.ko] undefined!
> ERROR: "iio_triggered_buffer_postenable" [drivers/staging/iio/iio_dummy.ko] undefined!
> ERROR: "iio_triggered_buffer_predisable" [drivers/staging/iio/iio_dummy.ko] undefined!
> ERROR: "iio_alloc_pollfunc" [drivers/staging/iio/iio_dummy.ko] undefined!
> ERROR: "iio_dealloc_pollfunc" [drivers/staging/iio/iio_dummy.ko] undefined!
Cc: Arnd Bergmann <arnd@arndb.de>
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
---
drivers/staging/iio/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/iio/Kconfig b/drivers/staging/iio/Kconfig
index fa38be0..2a15426 100644
--- a/drivers/staging/iio/Kconfig
+++ b/drivers/staging/iio/Kconfig
@@ -38,6 +38,7 @@ config IIO_SIMPLE_DUMMY_EVENTS
config IIO_SIMPLE_DUMMY_BUFFER
boolean "Buffered capture support"
select IIO_BUFFER
+ select IIO_TRIGGER
select IIO_KFIFO_BUF
help
Add buffered data capture to the simple dummy driver.
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: iio: dummy: Fix undefined symbol build error
2015-03-09 10:15 [PATCH] staging: iio: dummy: Fix undefined symbol build error Daniel Baluta
@ 2015-03-09 10:56 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2015-03-09 10:56 UTC (permalink / raw)
To: Daniel Baluta; +Cc: linux-iio, pmeerw, lars, knaack.h, arnd, fengguang.wu
On 09/03/15 10:15, Daniel Baluta wrote:
> CONFIG_SIMPLE_DUMMY_BUFFER compiles in iio_simple_dummy_buffer.c file
> which uses functions from industrialio-trigger.c.
>
> So, CONFIG_SIMPLE_DUMMY_BUFFER needs to select IIO_TRIGGER in order to
> avoid build error like this:
>
>> ERROR: "iio_trigger_notify_done" [drivers/staging/iio/iio_dummy.ko] undefined!
>> ERROR: "iio_triggered_buffer_postenable" [drivers/staging/iio/iio_dummy.ko] undefined!
>> ERROR: "iio_triggered_buffer_predisable" [drivers/staging/iio/iio_dummy.ko] undefined!
>> ERROR: "iio_alloc_pollfunc" [drivers/staging/iio/iio_dummy.ko] undefined!
>> ERROR: "iio_dealloc_pollfunc" [drivers/staging/iio/iio_dummy.ko] undefined!
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
Thanks,
This one had me rather confused as well.
Anyhow, applied to the fixes-togreg branch of iio.git.
Will push out later today.
Thanks,
Jonathan
> ---
> drivers/staging/iio/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/iio/Kconfig b/drivers/staging/iio/Kconfig
> index fa38be0..2a15426 100644
> --- a/drivers/staging/iio/Kconfig
> +++ b/drivers/staging/iio/Kconfig
> @@ -38,6 +38,7 @@ config IIO_SIMPLE_DUMMY_EVENTS
> config IIO_SIMPLE_DUMMY_BUFFER
> boolean "Buffered capture support"
> select IIO_BUFFER
> + select IIO_TRIGGER
> select IIO_KFIFO_BUF
> help
> Add buffered data capture to the simple dummy driver.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-09 10:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-09 10:15 [PATCH] staging: iio: dummy: Fix undefined symbol build error Daniel Baluta
2015-03-09 10:56 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).