From: Lars-Peter Clausen <lars@metafoo.de>
To: Peter Meerwald <pmeerw@pmeerw.net>,
Antoine Tenart <antoine.tenart@free-electrons.com>
Cc: sebastian.hesselbarth@gmail.com, jic23@kernel.org,
knaack.h@gmx.de, zmxu@marvell.com, jszhang@marvell.com,
yrliao@marvell.com, linux-iio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] iio: adc: add support for Berlin
Date: Fri, 20 Mar 2015 19:45:35 +0100 [thread overview]
Message-ID: <550C6ACF.3040902@metafoo.de> (raw)
In-Reply-To: <alpine.DEB.2.02.1503201819010.21628@pmeerw.net>
On 03/20/2015 06:43 PM, Peter Meerwald wrote:
> Hello Antoine,
>
>> This patch adds the support of the Berlin ADC, available on Berlin SoCs.
>> This ADC has 8 channels available, with one connected to a temperature
>> sensor.
>>
>> The particularity here, is that the temperature sensor connected to the
>> ADC has its own registers, and both the ADC and the temperature sensor
>> must be configured when using it.
>
> some quick comments inline below;
> sometimes this refers to berlin, sometimes to berlin2?
>
> probably these regmap_read() / _write() pairs could be MACRO()'d away
> somehow
There is regmap_update_bits(), which does the read-modify-update cycle.
next prev parent reply other threads:[~2015-03-20 18:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 13:36 [PATCH 0/4] ARM: berlin: ADC support Antoine Tenart
2015-03-20 13:36 ` [PATCH 1/4] iio: adc: add support for Berlin Antoine Tenart
2015-03-20 17:43 ` Peter Meerwald
2015-03-20 18:45 ` Lars-Peter Clausen [this message]
2015-03-21 12:50 ` Jonathan Cameron
2015-04-01 13:06 ` Antoine Tenart
2015-03-21 12:05 ` Paul Bolle
2015-03-20 13:36 ` [PATCH 2/4] Documentation: bindings: document the Berlin ADC driver Antoine Tenart
2015-03-20 13:36 ` [PATCH 3/4] ARM: berlin: add an ADC node for the BG2Q Antoine Tenart
2015-03-20 13:36 ` [PATCH 4/4] ARM: berlin: enable the ADC on the BG2Q DMP Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550C6ACF.3040902@metafoo.de \
--to=lars@metafoo.de \
--cc=antoine.tenart@free-electrons.com \
--cc=jic23@kernel.org \
--cc=jszhang@marvell.com \
--cc=knaack.h@gmx.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=sebastian.hesselbarth@gmail.com \
--cc=yrliao@marvell.com \
--cc=zmxu@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox