linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Octavian Purdila <octavian.purdila@intel.com>, jic23@kernel.org
Cc: pmeerw@pmeerw.net, knaack.h@gmx.de, linux-iio@vger.kernel.org
Subject: Re: [PATCH v6 0/3] iio: add support for hardware fifo
Date: Tue, 24 Mar 2015 13:27:40 +0100	[thread overview]
Message-ID: <5511583C.4080501@metafoo.de> (raw)
In-Reply-To: <1427049220-2876-1-git-send-email-octavian.purdila@intel.com>

On 03/22/2015 07:33 PM, Octavian Purdila wrote:
> Changes since v5:
>
>   * remove hwfifo_get_watermark operation from iio_info operations; the
>     driver can expose it dirrectly as a read-only buffer attribute and
>     there is not much gain from do it in the core
>
>   * in the case of non-blocking read flush with the full to read amount
>
>   * fix a few spelling errors
>
>   * add hwfifo_watermark_min, hwfifo_watermark_max,
>     hwfifo_watermark_available, hwfifo_enabled attributes to give
>     userspace more information of how to select a watermark that can
>     used to enable the hardware fifo
>
>   * rename hwfifo_flush to hwfifo_flush_to_buffer
>
>   * bmc150: avoid changing the iio_info to keep it constant
>
>   * bmc150: rename irq and threaded irq handlers
>

Looks pretty good to me now, thanks for doing this patch series. I'll try to 
give it some testing. If you don't hear anything else from me, that's a

Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>

      parent reply	other threads:[~2015-03-24 12:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-22 18:33 [PATCH v6 0/3] iio: add support for hardware fifo Octavian Purdila
2015-03-22 18:33 ` [PATCH v6 1/3] iio: add watermark logic to iio read and poll Octavian Purdila
2015-03-28 12:24   ` Jonathan Cameron
2015-03-29 15:15     ` Jonathan Cameron
2015-03-22 18:33 ` [PATCH v6 2/3] iio: add support for hardware fifo Octavian Purdila
2015-03-28 12:33   ` Jonathan Cameron
2015-03-22 18:33 ` [PATCH v6 3/3] iio: bmc150_accel: " Octavian Purdila
2015-03-28 12:36   ` Jonathan Cameron
2015-03-24 12:27 ` Lars-Peter Clausen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5511583C.4080501@metafoo.de \
    --to=lars@metafoo.de \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=octavian.purdila@intel.com \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).