From: Jonathan Cameron <jic23@kernel.org>
To: Richard Weinberger <richard@nod.at>, linux-kernel@vger.kernel.org
Cc: linux-iio@vger.kernel.org, linux-pm@vger.kernel.org,
dwmw2@infradead.org, dbaryshkov@gmail.com, sre@kernel.org,
jassisinghbrar@gmail.com, pmeerw@pmeerw.net, lars@metafoo.de,
knaack.h@gmx.de, tglx@linutronix.de, daniel.lezcano@linaro.org
Subject: Re: [PATCH 6/6] iio/adc/cc10001_adc.c: Fix !HAS_IOMEM build
Date: Mon, 30 Mar 2015 20:40:39 +0100 [thread overview]
Message-ID: <5519A6B7.1000706@kernel.org> (raw)
In-Reply-To: <550D5772.2010400@kernel.org>
On 21/03/15 11:35, Jonathan Cameron wrote:
> On 16/03/15 21:27, Richard Weinberger wrote:
>> Fixes:
>> drivers/built-in.o: In function `cc10001_adc_probe':
>> cc10001_adc.c:(.text+0x412e92): undefined reference to `devm_ioremap_resource'
>>
>> Signed-off-by: Richard Weinberger <richard@nod.at>
> Applied to the fixes-togreg branch of iio.git.
> Won't push this out for a day or so as waiting for Greg to pull the previous set.
>> ---
>> drivers/iio/adc/Kconfig | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
>> index 202daf8..46379b1 100644
>> --- a/drivers/iio/adc/Kconfig
>> +++ b/drivers/iio/adc/Kconfig
>> @@ -137,7 +137,8 @@ config AXP288_ADC
>>
>> config CC10001_ADC
>> tristate "Cosmic Circuits 10001 ADC driver"
>> - depends on HAS_IOMEM || HAVE_CLK || REGULATOR
>> + depends on HAVE_CLK || REGULATOR
>> + depends on HAS_IOMEM
>> select IIO_BUFFER
>> select IIO_TRIGGERED_BUFFER
>> help
>>
Hmm. Just noticed this whilst sending the pull request. That
HAVE_CLK || REGULATOR also seems rather implausible!
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2015-03-30 19:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 21:27 [PATCH 1/6] clocksource/sh_cmt.c: Fix !HAS_IOMEM build Richard Weinberger
2015-03-16 21:27 ` [PATCH 2/6] clocksource/sh_mtu2.c: " Richard Weinberger
2015-03-17 8:19 ` Geert Uytterhoeven
2015-03-20 14:04 ` Daniel Lezcano
2015-03-16 21:27 ` [PATCH 3/6] clocksource/sh_tmu.c: " Richard Weinberger
2015-03-17 8:19 ` Geert Uytterhoeven
2015-03-20 14:05 ` Daniel Lezcano
2015-03-16 21:27 ` [PATCH 4/6] power/reset/rmobile-reset.c: " Richard Weinberger
2015-03-17 8:19 ` Geert Uytterhoeven
2015-03-20 12:31 ` Sebastian Reichel
2015-03-16 21:27 ` [PATCH 5/6] mailbox/altera.c: " Richard Weinberger
2015-03-16 21:27 ` [PATCH 6/6] iio/adc/cc10001_adc.c: " Richard Weinberger
2015-03-21 11:35 ` Jonathan Cameron
2015-03-30 19:40 ` Jonathan Cameron [this message]
2015-03-17 8:18 ` [PATCH 1/6] clocksource/sh_cmt.c: " Geert Uytterhoeven
2015-03-20 14:05 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5519A6B7.1000706@kernel.org \
--to=jic23@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=jassisinghbrar@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=richard@nod.at \
--cc=sre@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).