[PATCH] iio: light: hid-sensor-prox: Fix modifier

[PATCH] iio: light: hid-sensor-prox: Fix modifier

[Srinivas Pandruvada]

Currently in_proximity_(null)_raw is getting presented as raw sysfs
attribute. Same with the scan_elements.
The modifier doesn't apply to this channel.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
 drivers/iio/light/hid-sensor-prox.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/iio/light/hid-sensor-prox.c b/drivers/iio/light/hid-sensor-prox.c
index 91ecc46..dc618b4 100644
--- a/drivers/iio/light/hid-sensor-prox.c
+++ b/drivers/iio/light/hid-sensor-prox.c
@@ -43,8 +43,6 @@ struct prox_state {
 static const struct iio_chan_spec prox_channels[] = {
 	{
 		.type = IIO_PROXIMITY,
-		.modified = 1,
-		.channel2 = IIO_NO_MOD,
 		.info_mask_separate = BIT(IIO_CHAN_INFO_RAW),
 		.info_mask_shared_by_type = BIT(IIO_CHAN_INFO_OFFSET) |
 		BIT(IIO_CHAN_INFO_SCALE) |
-- 
2.1.0

Re: [PATCH] iio: light: hid-sensor-prox: Fix modifier

[Daniel Baluta]

On Wed, Apr 15, 2015 at 12:53 AM, Srinivas Pandruvada
<srinivas.pandruvada@linux.intel.com> wrote:
> Currently in_proximity_(null)_raw is getting presented as raw sysfs
> attribute. Same with the scan_elements.
> The modifier doesn't apply to this channel.
>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---

Would be also nice to add a line like this:

Fixes COMMIT_ID ("Commit subject")

in order for stable teams to pick this up.

thanks,
Daniel.

Re: [PATCH] iio: light: hid-sensor-prox: Fix modifier

[Srinivas Pandruvada]

On Wed, 2015-04-15 at 15:01 +0300, Daniel Baluta wrote: 
> On Wed, Apr 15, 2015 at 12:53 AM, Srinivas Pandruvada
> <srinivas.pandruvada@linux.intel.com> wrote:
> > Currently in_proximity_(null)_raw is getting presented as raw sysfs
> > attribute. Same with the scan_elements.
> > The modifier doesn't apply to this channel.
> >
> > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> > ---
> 
> Would be also nice to add a line like this:
> 
> Fixes COMMIT_ID ("Commit subject")
> 
> in order for stable teams to pick this up.
We can add tag
Cc: stable@vger.kernel.org

Usually Jonathan copies after his merge.

Thanks,
Srinivas

> 
> thanks,
> Daniel.

Re: [PATCH] iio: light: hid-sensor-prox: Fix modifier

[Jonathan Cameron]

On 16/04/15 16:54, Srinivas Pandruvada wrote:
> On Wed, 2015-04-15 at 15:01 +0300, Daniel Baluta wrote: 
>> On Wed, Apr 15, 2015 at 12:53 AM, Srinivas Pandruvada
>> <srinivas.pandruvada@linux.intel.com> wrote:
>>> Currently in_proximity_(null)_raw is getting presented as raw sysfs
>>> attribute. Same with the scan_elements.
>>> The modifier doesn't apply to this channel.
>>>
>>> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
>>> ---
>>
>> Would be also nice to add a line like this:
>>
>> Fixes COMMIT_ID ("Commit subject")
It is a nice convention, but when it's been a bug for all versions of the
file that have ever been in the tree, it's not so important.
>>
>> in order for stable teams to pick this up.
> We can add tag
> Cc: stable@vger.kernel.org
> 
> Usually Jonathan copies after his merge.
I will indeed.

Applied to the fixes-togreg branch of iio.git and marked for
stable.
> 
> Thanks,
> Srinivas
> 
>>
>> thanks,
>> Daniel.
> 
>