Re: [PATCH] iio:prox:sx9500 trivial simplification of return path in init function.

[Jonathan Cameron <jic23@kernel.org>]

On 04/05/15 10:38, Jonathan Cameron wrote:
> On 04/05/15 10:22, Daniel Baluta wrote:
>> On Sat, May 2, 2015 at 1:29 PM, Jonathan Cameron <jic23@kernel.org> wrote:
>>> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
>>> Reported-by: kbuild test robot <fengguang.wu@intel.com>
>>> Cc: Vlad Dogaru <vlad.dogaru@intel.com>
>>> ---
>>>  drivers/iio/proximity/sx9500.c | 4 +---
>>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/iio/proximity/sx9500.c b/drivers/iio/proximity/sx9500.c
>>> index f1e9d734b6b6..323de9510ba5 100644
>>> --- a/drivers/iio/proximity/sx9500.c
>>> +++ b/drivers/iio/proximity/sx9500.c
>>> @@ -860,10 +860,8 @@ static int sx9500_init_device(struct iio_dev *indio_dev)
>>>         }
>>>
>>>         ret = sx9500_init_compensation(indio_dev);
>>> -       if (ret < 0)
>>> -               return ret;
>>>
>>> -       return 0;
>>> +       return ret;
>>>  }
>>
>> Or, better directly return sx9500_init_comp...
> oops. Good point ;)
Applied with the entirely obvious change that I'd missed and Vlad hadn't
noticed made!

Btw Vlad, this is why even stupidly simple patches ideally get a review.
Often they have the silliest mistakes in them.

Thanks All,

I'm travelling for a few days so not sure when I'll push out my local
tree.
>>
>> Daniel.
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>