From: Jonathan Cameron <jic23@kernel.org>
To: Daniel Baluta <daniel.baluta@gmail.com>, Antonio Ospite <ao2@ao2.it>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
Bastien Nocera <hadess@hadess.net>
Subject: Re: [PATCHv2 2/2] iio: accel: kxcjk-1013: add some blank lines for readability
Date: Mon, 04 May 2015 17:14:21 +0100 [thread overview]
Message-ID: <55479ADD.7060007@kernel.org> (raw)
In-Reply-To: <CAEnQRZCUqdRxizNCddWqzYtTJY43RCs=4Qrv0yDxytqW_aTKww@mail.gmail.com>
On 04/05/15 11:51, Daniel Baluta wrote:
> On Mon, May 4, 2015 at 12:13 PM, Antonio Ospite <ao2@ao2.it> wrote:
>> Some extra blank lines between if checks don't hurt and improve
>> readability.
>>
>> Signed-off-by: Antonio Ospite <ao2@ao2.it>
>> Cc: Jonathan Cameron <jic23@kernel.org>
>> Cc: Bastien Nocera <hadess@hadess.net>
>> Cc: linux-iio@vger.kernel.org
>> ---
>
> Looks nice :).
>
> Reviewed-by: Daniel Baluta <daniel.baluta@intel.com>
added to the patch.
>
>> drivers/iio/accel/kxcjk-1013.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
>> index 5b7a860..937bfc2 100644
>> --- a/drivers/iio/accel/kxcjk-1013.c
>> +++ b/drivers/iio/accel/kxcjk-1013.c
>> @@ -1147,8 +1147,10 @@ static const char *kxcjk1013_match_acpi_device(struct device *dev,
>> id = acpi_match_device(dev->driver->acpi_match_table, dev);
>> if (!id)
>> return NULL;
>> +
>> if (strcmp(id->id, "SMO8500") == 0)
>> *is_smo8500_device = true;
>> +
>> *chipset = (enum kx_chipset)id->driver_data;
>>
>> return dev_name(dev);
>> @@ -1163,6 +1165,7 @@ static int kxcjk1013_gpio_probe(struct i2c_client *client,
>>
>> if (!client)
>> return -EINVAL;
>> +
>> if (data->is_smo8500_device)
>> return -ENOTSUPP;
>>
>> --
>> 2.1.4
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2015-05-04 16:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 9:13 [PATCHv2 0/2] iio: accel: kxcjk-1013: new ACPI id and Antonio Ospite
2015-05-04 9:13 ` [PATCHv2 1/2] iio: accel: kxcjk-1013: add the "KXCJ9000" ACPI id Antonio Ospite
2015-05-04 10:36 ` Jonathan Cameron
2015-05-04 10:50 ` Daniel Baluta
2015-05-04 16:13 ` Jonathan Cameron
2015-05-04 9:13 ` [PATCHv2 2/2] iio: accel: kxcjk-1013: add some blank lines for readability Antonio Ospite
2015-05-04 10:51 ` Daniel Baluta
2015-05-04 16:14 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55479ADD.7060007@kernel.org \
--to=jic23@kernel.org \
--cc=ao2@ao2.it \
--cc=daniel.baluta@gmail.com \
--cc=hadess@hadess.net \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox