public inbox for linux-iio@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: linux-iio@vger.kernel.org, srinivas.pandruvada@linux.intel.com,
	Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH 1/2] iio: light: hid-sensor-prox: Fit assignment in one line
Date: Sun, 10 May 2015 20:34:03 +0100	[thread overview]
Message-ID: <554FB2AB.3040901@kernel.org> (raw)
In-Reply-To: <1431111241-7472-1-git-send-email-festevam@gmail.com>

On 08/05/15 19:54, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> There is no need to do the assignment to indio_dev->num_channels in two
> lines code.
> 
> Put it in one line.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Fair enough, but I'll have to wait for the fix to the line above
this to propagate through to the staging-next tree before applying this.
Please do remind me if I seem to have forgotten about it!

Jonathan
> ---
>  drivers/iio/light/hid-sensor-prox.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/light/hid-sensor-prox.c b/drivers/iio/light/hid-sensor-prox.c
> index 124a8f8..4ed42df 100644
> --- a/drivers/iio/light/hid-sensor-prox.c
> +++ b/drivers/iio/light/hid-sensor-prox.c
> @@ -286,8 +286,7 @@ static int hid_prox_probe(struct platform_device *pdev)
>  		goto error_free_dev_mem;
>  	}
>  
> -	indio_dev->num_channels =
> -				ARRAY_SIZE(prox_channels);
> +	indio_dev->num_channels = ARRAY_SIZE(prox_channels);
>  	indio_dev->dev.parent = &pdev->dev;
>  	indio_dev->info = &prox_info;
>  	indio_dev->name = name;
> 


  parent reply	other threads:[~2015-05-10 19:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-08 18:54 [PATCH 1/2] iio: light: hid-sensor-prox: Fit assignment in one line Fabio Estevam
2015-05-08 18:54 ` [PATCH 2/2] iio: light: hid-sensor-prox: Use devm_iio_device_register() Fabio Estevam
2015-05-10 19:31   ` Jonathan Cameron
2015-05-10 19:34 ` Jonathan Cameron [this message]
2015-06-14 14:08 ` [PATCH 1/2] iio: light: hid-sensor-prox: Fit assignment in one line Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=554FB2AB.3040901@kernel.org \
    --to=jic23@kernel.org \
    --cc=fabio.estevam@freescale.com \
    --cc=festevam@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox