public inbox for linux-iio@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: linux-iio@vger.kernel.org
Cc: "Vianney le Clément de Saint-Marcq"
	<vianney.leclement@essensium.com>,
	"Peter Meerwald" <pmeerw@pmeerw.net>
Subject: Re: [PATCH] iio:temp:mlx90614 trivial drop of unnecessary ret return from write_raw.
Date: Wed, 13 May 2015 18:40:51 +0100	[thread overview]
Message-ID: <55538CA3.2050806@kernel.org> (raw)
In-Reply-To: <1430562902-28068-1-git-send-email-jic23@kernel.org>

On 02/05/15 11:35, Jonathan Cameron wrote:
> This is mostly part of an effort to clean out our current warnings
> and make the autobuilder build reports more useful.
> 
> Still a worthwhile if trivial cleanup!
> 
> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Cc: Vianney le Clément de Saint-Marcq <vianney.leclement@essensium.com>
> Cc: Peter Meerwald <pmeerw@pmeerw.net>
Applied to the togreg branch of iio.git - pushed out as testing.

Jonathan
> ---
>  drivers/iio/temperature/mlx90614.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/temperature/mlx90614.c b/drivers/iio/temperature/mlx90614.c
> index b2d3b56f1260..cb2e8ad8bfdc 100644
> --- a/drivers/iio/temperature/mlx90614.c
> +++ b/drivers/iio/temperature/mlx90614.c
> @@ -254,9 +254,7 @@ static int mlx90614_write_raw(struct iio_dev *indio_dev,
>  		mutex_unlock(&data->lock);
>  		mlx90614_power_put(data);
>  
> -		if (ret < 0)
> -			return ret;
> -		return 0;
> +		return ret;
>  	default:
>  		return -EINVAL;
>  	}
> 


      reply	other threads:[~2015-05-13 17:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-02 10:35 [PATCH] iio:temp:mlx90614 trivial drop of unnecessary ret return from write_raw Jonathan Cameron
2015-05-13 17:40 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55538CA3.2050806@kernel.org \
    --to=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=vianney.leclement@essensium.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox