linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Martin Fuzzey <mfuzzey@parkeon.com>, Peter Meerwald <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>
Subject: Re: [PATCH V4 2/7] iio: mma8452: Add access to registers via DebugFS
Date: Sun, 17 May 2015 10:31:24 +0100	[thread overview]
Message-ID: <55585FEC.4060906@kernel.org> (raw)
In-Reply-To: <20150513102640.27803.39257.stgit@localhost>

On 13/05/15 11:26, Martin Fuzzey wrote:
> Signed-off-by: Martin Fuzzey <mfuzzey@parkeon.com>
applied.
> ---
>  drivers/iio/accel/mma8452.c |   25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
> index 001a7db..877ce29 100644
> --- a/drivers/iio/accel/mma8452.c
> +++ b/drivers/iio/accel/mma8452.c
> @@ -34,6 +34,8 @@
>  #define MMA8452_CTRL_REG2 0x2b
>  #define MMA8452_CTRL_REG2_RST		BIT(6)
>  
> +#define MMA8452_MAX_REG 0x31
> +
>  #define MMA8452_STATUS_DRDY (BIT(2) | BIT(1) | BIT(0))
>  
>  #define MMA8452_CTRL_DR_MASK (BIT(5) | BIT(4) | BIT(3))
> @@ -292,6 +294,28 @@ done:
>  	return IRQ_HANDLED;
>  }
>  
> +static int mma8452_reg_access_dbg(struct iio_dev *indio_dev,
> +				  unsigned reg, unsigned writeval,
> +				  unsigned *readval)
> +{
> +	int ret;
> +	struct mma8452_data *data = iio_priv(indio_dev);
> +
> +	if (reg > MMA8452_MAX_REG)
> +		return -EINVAL;
> +
> +	if (!readval)
> +		return mma8452_change_config(data, reg, writeval);
> +
> +	ret = i2c_smbus_read_byte_data(data->client, reg);
> +	if (ret < 0)
> +		return ret;
> +
> +	*readval = ret;
> +
> +	return 0;
> +}
> +
>  #define MMA8452_CHANNEL(axis, idx) { \
>  	.type = IIO_ACCEL, \
>  	.modified = 1, \
> @@ -331,6 +355,7 @@ static const struct iio_info mma8452_info = {
>  	.attrs = &mma8452_group,
>  	.read_raw = &mma8452_read_raw,
>  	.write_raw = &mma8452_write_raw,
> +	.debugfs_reg_access = &mma8452_reg_access_dbg,
>  	.driver_module = THIS_MODULE,
>  };
>  
> 


  reply	other threads:[~2015-05-17  9:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-13 10:26 [PATCH V4 0/7] iio: mma8452 enhancements Martin Fuzzey
2015-05-13 10:26 ` [PATCH V4 1/7] iio: mma8452: Initialise before activating Martin Fuzzey
2015-05-17  9:29   ` Jonathan Cameron
2015-05-13 10:26 ` [PATCH V4 2/7] iio: mma8452: Add access to registers via DebugFS Martin Fuzzey
2015-05-17  9:31   ` Jonathan Cameron [this message]
2015-05-13 10:26 ` [PATCH V4 3/7] iio: core: add high pass filter attributes Martin Fuzzey
2015-05-17  9:32   ` Jonathan Cameron
2015-05-13 10:26 ` [PATCH V4 4/7] iio: mma8452: Basic support for transient events Martin Fuzzey
2015-05-17  9:36   ` Jonathan Cameron
2015-05-13 10:26 ` [PATCH V4 5/7] iio: mma8452: Add support for transient event debouncing Martin Fuzzey
2015-05-17  9:38   ` Jonathan Cameron
2015-05-13 10:26 ` [PATCH V4 6/7] iio: mma8452: Add highpass filter configuration Martin Fuzzey
2015-05-17  9:48   ` Jonathan Cameron
2015-05-18  8:17     ` Martin Fuzzey
2015-05-22 17:58       ` Jonathan Cameron
2015-05-13 10:26 ` [PATCH V4 7/7] iio: mma8452: Add support for interrupt driven triggers Martin Fuzzey
2015-05-17  9:55   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55585FEC.4060906@kernel.org \
    --to=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=mfuzzey@parkeon.com \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).