From: Jonathan Cameron <jic23@kernel.org>
To: Octavian Purdila <octavian.purdila@intel.com>
Cc: Tiberiu Breana <tiberiu.a.breana@intel.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
Peter Meerwald <pmeerw@pmeerw.net>
Subject: Re: [PATCH v3 2/2] iio: light: Add threshold interrupt support for STK3310
Date: Fri, 22 May 2015 18:54:21 +0100 [thread overview]
Message-ID: <555F6D4D.5060508@kernel.org> (raw)
In-Reply-To: <CAE1zot+hMJAGr8xstZJTe_Doh=C+2Veruyo+S4Or7Y3n=gdbCQ@mail.gmail.com>
On 20/05/15 10:46, Octavian Purdila wrote:
> On Thu, May 7, 2015 at 1:31 PM, Jonathan Cameron <jic23@kernel.org> wrote:
>>
>> On 27/04/15 16:34, Tiberiu Breana wrote:
>>> Added interrupt support for proximity threshold events
>>> to the stk3310 driver.
>> I've not objection to the split, but also wouldn't have minded having
>> this in the original driver split (just in case you are doing it to make
>> reviewing easier - in this sort of thing it makes little difference!)
>>>
>>> Signed-off-by: Tiberiu Breana <tiberiu.a.breana@intel.com>
>> Again, nice patch. My only comment below is about the fact I should
>> find out what happened to the thoughts about moving the gpio/interrupt
>> setup code into ACPI to avoid having the same 10 lines in every driver.
>>
>
> Mika send another version of the patch set and it was accepted and
> merged into the GPIO tree:
>
> https://lkml.org/lkml/2015/5/6/281
Cool. Once that has worked it's way through yets
have a general cleanup of the cut and paste versions we have throughout
IIO. Anyone want to take this on?
Jonathan
next prev parent reply other threads:[~2015-05-22 17:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 15:33 [PATCH v3 0/2] Add support for Sensortek STK3310 Tiberiu Breana
2015-04-27 15:34 ` [PATCH v3 1/2] iio: light: " Tiberiu Breana
2015-05-07 22:40 ` Jonathan Cameron
2015-04-27 15:34 ` [PATCH v3 2/2] iio: light: Add threshold interrupt support for STK3310 Tiberiu Breana
2015-05-07 10:31 ` Jonathan Cameron
2015-05-20 9:46 ` Octavian Purdila
2015-05-22 17:54 ` Jonathan Cameron [this message]
2015-05-22 18:03 ` Jonathan Cameron
2015-06-02 20:47 ` Octavian Purdila
2015-06-02 22:17 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555F6D4D.5060508@kernel.org \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=octavian.purdila@intel.com \
--cc=pmeerw@pmeerw.net \
--cc=tiberiu.a.breana@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).