From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:45290 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756676AbbEVRy1 (ORCPT ); Fri, 22 May 2015 13:54:27 -0400 Message-ID: <555F6D4D.5060508@kernel.org> Date: Fri, 22 May 2015 18:54:21 +0100 From: Jonathan Cameron MIME-Version: 1.0 To: Octavian Purdila CC: Tiberiu Breana , "linux-iio@vger.kernel.org" , Peter Meerwald Subject: Re: [PATCH v3 2/2] iio: light: Add threshold interrupt support for STK3310 References: <1430148841-30947-1-git-send-email-tiberiu.a.breana@intel.com> <1430148841-30947-3-git-send-email-tiberiu.a.breana@intel.com> <554B3F05.1010600@kernel.org> In-Reply-To: Content-Type: text/plain; charset=utf-8 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 20/05/15 10:46, Octavian Purdila wrote: > On Thu, May 7, 2015 at 1:31 PM, Jonathan Cameron wrote: >> >> On 27/04/15 16:34, Tiberiu Breana wrote: >>> Added interrupt support for proximity threshold events >>> to the stk3310 driver. >> I've not objection to the split, but also wouldn't have minded having >> this in the original driver split (just in case you are doing it to make >> reviewing easier - in this sort of thing it makes little difference!) >>> >>> Signed-off-by: Tiberiu Breana >> Again, nice patch. My only comment below is about the fact I should >> find out what happened to the thoughts about moving the gpio/interrupt >> setup code into ACPI to avoid having the same 10 lines in every driver. >> > > Mika send another version of the patch set and it was accepted and > merged into the GPIO tree: > > https://lkml.org/lkml/2015/5/6/281 Cool. Once that has worked it's way through yets have a general cleanup of the cut and paste versions we have throughout IIO. Anyone want to take this on? Jonathan