From: Jonathan Cameron <jic23@kernel.org>
To: Vladimirs Ambrosovs <rodriguez.twister@gmail.com>,
sudipm.mukherjee@gmail.com, daniel.baluta@intel.com,
dan.carpenter@oracle.com, gregkh@linuxfoundation.org
Cc: cristina.opriceana@gmail.com,
driverdev-devel@linuxdriverproject.org,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v3 3/3] staging: iio_simple_dummy: fix module_param type
Date: Mon, 01 Jun 2015 11:23:12 +0100 [thread overview]
Message-ID: <556C3290.3040605@kernel.org> (raw)
In-Reply-To: <1432974017-24547-4-git-send-email-rodriguez.twister@gmail.com>
On 30/05/15 09:20, Vladimirs Ambrosovs wrote:
> Fix the module_param "instances" type to uint, since the variable type
> holding the value is unsigned.
>
> Signed-off-by: Vladimirs Ambrosovs <rodriguez.twister@gmail.com>
Applied to the togreg branch of iio.git - which will get pushed
out as testing in a few days. Or just possibly tonight if the hotel
network is working well and I can remember my password :)
Jonathan
> ---
> drivers/staging/iio/iio_simple_dummy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/iio_simple_dummy.c b/drivers/staging/iio/iio_simple_dummy.c
> index dc9482c7..1629a8a 100644
> --- a/drivers/staging/iio/iio_simple_dummy.c
> +++ b/drivers/staging/iio/iio_simple_dummy.c
> @@ -30,7 +30,7 @@
> * dummy devices are registered.
> */
> static unsigned instances = 1;
> -module_param(instances, int, 0);
> +module_param(instances, uint, 0);
>
> /* Pointer array used to fake bus elements */
> static struct iio_dev **iio_dummy_devs;
>
prev parent reply other threads:[~2015-06-01 21:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-30 8:20 [PATCH v3 0/3] staging: iio_simple_dummy: minor driver fixes Vladimirs Ambrosovs
2015-05-30 8:20 ` [PATCH v3 1/3] staging: iio_simple_dummy: fix init function Vladimirs Ambrosovs
2015-06-01 10:21 ` Jonathan Cameron
2015-05-30 8:20 ` [PATCH v3 2/3] staging: iio_simple_dummy: fix return types Vladimirs Ambrosovs
2015-06-01 10:21 ` Jonathan Cameron
2015-05-30 8:20 ` [PATCH v3 3/3] staging: iio_simple_dummy: fix module_param type Vladimirs Ambrosovs
2015-06-01 10:23 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556C3290.3040605@kernel.org \
--to=jic23@kernel.org \
--cc=cristina.opriceana@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=daniel.baluta@intel.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-iio@vger.kernel.org \
--cc=rodriguez.twister@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).