From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3] iio: adc: hi-843x: Holt HI-8435/8436/8437 descrete ADC
Date: Wed, 03 Jun 2015 10:46:17 +0300 [thread overview]
Message-ID: <556EB0C9.2040606@cogentembedded.com> (raw)
In-Reply-To: <1433315157.2361.100.camel@x220>
Hi Paul,
On 03.06.2015 10:05, Paul Bolle wrote:
> Just a nit, that I spotted while scanning for other issues.
>
> On Mon, 2015-06-01 at 15:20 +0300, Vladimir Barinov wrote:
>> --- /dev/null
>> +++ b/drivers/iio/adc/hi-843x.c
>> +ssize_t hi843x_debounce_soft_show(struct device *dev,
>> + struct device_attribute *attr, char *buf)
>> +{
>> + [...]
>> +}
>> +
>> +[...]
>> +
>> +ssize_t hi843x_threshold_socval_store(struct device *dev,
>> + struct device_attribute *attr,
>> + const char *buf, size_t len)
>> +{
>> + [...]
>> +}
> It seems all these *_show and *_store functions should be made static,
> right?
Right. Thank you for pointing to this.
Regards,
Vladimir
next prev parent reply other threads:[~2015-06-03 7:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 12:17 [PATCH 0/3] iio: adc: hi-843x: Add Holt HI-8435/8436/8437 descrete ADC Vladimir Barinov
2015-06-01 12:20 ` [PATCH 1/3] iio: adc: hi-843x: " Vladimir Barinov
2015-06-01 12:55 ` Peter Meerwald
2015-06-01 14:41 ` Vladimir Barinov
2015-06-03 7:05 ` Paul Bolle
2015-06-03 7:46 ` Vladimir Barinov [this message]
2015-06-07 16:11 ` Jonathan Cameron
2015-06-18 19:33 ` Lars-Peter Clausen
2015-06-18 21:41 ` Vladimir Barinov
2015-06-21 14:14 ` Jonathan Cameron
2015-06-24 9:25 ` Vladimir Barinov
2015-06-01 12:20 ` [PATCH 2/3] dt: Add vendor prefix 'holt' Vladimir Barinov
2015-06-01 12:20 ` [PATCH 3/3] dt: Document Holt descrete ADC bindings Vladimir Barinov
2015-06-07 15:43 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556EB0C9.2040606@cogentembedded.com \
--to=vladimir.barinov@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=pebolle@tiscali.nl \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).