From: Jonathan Cameron <jic23@kernel.org>
To: Daniel Baluta <daniel.baluta@intel.com>, pmeerw@pmeerw.net
Cc: knaack.h@gmx.de, lars@metafoo.de, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v2 5/6] iio: magnetometer: mmc35240: Fix sensitivity on z-axis
Date: Sun, 07 Jun 2015 16:34:36 +0100 [thread overview]
Message-ID: <5574648C.2090100@kernel.org> (raw)
In-Reply-To: <1433502195-30296-6-git-send-email-daniel.baluta@intel.com>
On 05/06/15 12:03, Daniel Baluta wrote:
> Datasheet says (Page 2) that typical value for sensitivity
> for 16 bits mode on Z-axis is 770. Anyhow, looking at the
> input driver provided by Memsic the value for MMC35240 is
> 1024.
>
> Also, testing shows that using 1024 for Z-axis senzitivity
> offers better results.
>
> Fixes: abeb6b1e7b ("iio: magnetometer: Add support for MEMSIC MMC35240")
> Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
applied
> ---
> drivers/iio/magnetometer/mmc35240.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/magnetometer/mmc35240.c b/drivers/iio/magnetometer/mmc35240.c
> index 7bc72b3..73fa111 100644
> --- a/drivers/iio/magnetometer/mmc35240.c
> +++ b/drivers/iio/magnetometer/mmc35240.c
> @@ -77,7 +77,7 @@ static const struct {
> } mmc35240_props_table[] = {
> /* 16 bits, 100Hz ODR */
> {
> - {1024, 1024, 770},
> + {1024, 1024, 1024},
> 32768,
> },
> /* 16 bits, 200Hz ODR */
>
next prev parent reply other threads:[~2015-06-07 15:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 11:03 [PATCH v2 0/6] Memsic MMC35230 magnetometer fixes Daniel Baluta
2015-06-05 11:03 ` [PATCH v2 1/6] iio: magnetometer: mmc35240: i2c device name should be lower case Daniel Baluta
2015-06-07 15:33 ` Jonathan Cameron
2015-06-05 11:03 ` [PATCH v2 2/6] iio: magnetometer: mmc35240: NULL terminate attribute array Daniel Baluta
2015-06-07 15:33 ` Jonathan Cameron
2015-06-05 11:03 ` [PATCH v2 3/6] iio: magnetometer: mmc35240: Fix broken processed value Daniel Baluta
2015-06-07 15:34 ` Jonathan Cameron
2015-06-05 11:03 ` [PATCH v2 4/6] iio: magnetometer: mmc35240: Use a smaller sleep value Daniel Baluta
2015-06-07 15:34 ` Jonathan Cameron
2015-06-05 11:03 ` [PATCH v2 5/6] iio: magnetometer: mmc35240: Fix sensitivity on z-axis Daniel Baluta
2015-06-07 15:34 ` Jonathan Cameron [this message]
2015-06-05 11:03 ` [PATCH v2 6/6] iio: magnetometer: mmc35240: Add compensation for raw values Daniel Baluta
2015-06-07 15:35 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5574648C.2090100@kernel.org \
--to=jic23@kernel.org \
--cc=daniel.baluta@intel.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).